all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Robert Cochran <robert-emacs@cochranmail.com>
Cc: emacs-devel@gnu.org, "T.V Raman" <raman@google.com>
Subject: Re: [PATCH] Enable persistent naming for tabs
Date: Sun, 27 Oct 2019 00:46:36 +0300	[thread overview]
Message-ID: <87wocruqmb.fsf@mail.linkov.net> (raw)
In-Reply-To: <87r230akt8.fsf@cochranmail.com> (Robert Cochran's message of "Fri, 25 Oct 2019 08:47:47 -0700")

>>> C) Disable tab-bar-mode
>>
>> While implementing tab closing undo, I added disabling tab-bar-mode
>> because it was easier to just add this line:
>>
>>                (or (<= (length tabs) 1) ; closed the last tab
>>
>> But please remove this from the default behavior because
>
> Sorry, I didn't quite understand what you wanted me to do there, so I
> didn't try to address it.

I see that you already resolved this after rebasing.  Thanks!
Now your patch is pushed to master without merge conflicts.

>> I noticed that it disables tab-bar on all frames, whereas
>> it would make more sense to disable tab-bar only on the
>> selected frame.

I meant we could have separate tab-bar-mode to disable it only
on the selected frame, and global-tab-bar-mode to disable it
globally on all frames.

> It occurred to me in the process of writing this up that it might be
> useful to provide hook variables for creating and closing tabs -
> 'tab-bar-tab-open-hook' and 'tab-bar-tab-close-hook' perhaps? Standard
> fare on those - a list of functions that take the tab as an argument,
> probably called as the last task of tab creation and the first task of
> tab closing? Thoughts?

Not sure if this could be a hook on tab-bar basic events,
or a customizable function.  Also not clear whether to call it
before or after the main body.

We need to collect more examples of use cases to decide
on the implementation.



  parent reply	other threads:[~2019-10-26 21:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10  1:03 [PATCH] Enable persistent naming for tabs Robert Cochran
2019-10-10 21:43 ` Juri Linkov
     [not found]   ` <87ftjz6v4d.fsf@cochranmail.com>
2019-10-13 19:53     ` Juri Linkov
2019-10-15 21:45       ` Juri Linkov
2019-10-20 16:17       ` Juri Linkov
2019-10-20 23:54         ` T.V Raman
2019-10-21 21:34           ` Juri Linkov
2019-10-23 16:22             ` Robert Cochran
2019-10-23 20:41               ` Juri Linkov
2019-10-25 15:47                 ` Robert Cochran
2019-10-25 16:01                   ` Robert Cochran
2019-11-03 22:08                     ` Robert Cochran
2019-11-03 22:37                       ` Juri Linkov
2019-10-26 21:46                   ` Juri Linkov [this message]
2019-10-30 18:35                     ` Robert Cochran
2019-10-30 21:52                       ` Juri Linkov
2019-10-30 23:05                         ` Juri Linkov
2019-10-31  1:50                           ` Robert Cochran
2019-10-31 21:17                             ` Juri Linkov
2019-10-27 23:10               ` Juri Linkov
  -- strict thread matches above, loose matches on Subject: below --
2019-10-08 22:26 Robert Cochran
2019-10-09 16:02 ` Eli Zaretskii
2019-10-09 22:58 ` Juri Linkov
2019-10-23 20:53 ` Kalman Reti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wocruqmb.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=emacs-devel@gnu.org \
    --cc=raman@google.com \
    --cc=robert-emacs@cochranmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.