From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#39546: 28.0.50; Do not require subr-x at run time Date: Mon, 10 Feb 2020 20:19:05 +0100 Message-ID: <87wo8up7x2.fsf@gnu.org> References: <87k14uwnjl.fsf@gmail.com> <831rr2cvci.fsf@gnu.org> <83r1z2bau6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="98636"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39546@debbugs.gnu.org, larsi@gnus.org, michael.albinus@gmx.de, Tino Calancha To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 10 20:20:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j1EbM-000PXh-Jc for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Feb 2020 20:20:12 +0100 Original-Received: from localhost ([::1]:37724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1EbL-0002t4-Ei for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Feb 2020 14:20:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54819) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1EbD-0002sn-Lx for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 14:20:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1EbC-0004vo-MG for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 14:20:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49446) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1EbC-0004vW-Iv for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 14:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j1EbC-0001O6-EE for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2020 14:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Feb 2020 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39546 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39546-submit@debbugs.gnu.org id=B39546.15813623595274 (code B ref 39546); Mon, 10 Feb 2020 19:20:02 +0000 Original-Received: (at 39546) by debbugs.gnu.org; 10 Feb 2020 19:19:19 +0000 Original-Received: from localhost ([127.0.0.1]:55419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1EaV-0001N0-1R for submit@debbugs.gnu.org; Mon, 10 Feb 2020 14:19:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1EaR-0001Mm-Tb for 39546@debbugs.gnu.org; Mon, 10 Feb 2020 14:19:17 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j1EaM-0003Vw-Lj; Mon, 10 Feb 2020 14:19:10 -0500 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:43187) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1j1EaL-0001ZY-Sp; Mon, 10 Feb 2020 14:19:10 -0500 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 6821C2013C; Mon, 10 Feb 2020 14:19:09 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 10 Feb 2020 14:19:09 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedriedugdduudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecukfhppeekgedrudefvddrud dthedrudekvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhorhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieejfe ekjeekgedqieefhedvleekqdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilhdr fhhm X-ME-Proxy: Original-Received: from thinkpad-t440p (p548469b6.dip0.t-ipconnect.de [84.132.105.182]) by mail.messagingengine.com (Postfix) with ESMTPA id 40B793280063; Mon, 10 Feb 2020 14:19:07 -0500 (EST) In-Reply-To: <83r1z2bau6.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 10 Feb 2020 19:39:45 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175892 Archived-At: Eli Zaretskii writes: >> > subr.el is preloaded, so doing that will enlarge the Emacs memory >> > footprint. Is that function important enough to have it preloaded? >> According with its usage at Emacs source (only at json.el) I'd say >> the answer to your question is: not worth to be at subr.el. > > That's what I thought. So I suggest to find another file to host this > function, if we want subr-x.el to have only macros and defsubst's. Given that it's only a wrapper around replace-buffer-contents which is always available, I think it shouldn't be hidden too much. AFAIK, I've put it in subr.el first and requests were made to move it to subr-x.el. I've already submitted patches to hindent (and I think to some other 3rd party package providing code formatting by replacing with the output of some formatting tool) using that function. Anyway, if it is going to be moved, I'd to ask you to move it in emacs-27 so that I can check for and fix external usages I know of without having to distinguish emacs versions. Bye, Tassilo