From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#39504: 27.0.60; [PATCH] eww/shr: Ensure faces of enclosing elements apply to elements Date: Thu, 20 Feb 2020 23:19:32 +0100 Message-ID: <87wo8gsxzf.fsf@gmail.com> References: <87zhdundsc.fsf@gmail.com> <87eeup5qru.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="33320"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39504@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 20 23:20:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j4uB2-0008YA-FA for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Feb 2020 23:20:12 +0100 Original-Received: from localhost ([::1]:49908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4uB1-0000em-56 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Feb 2020 17:20:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52940) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4uAt-0000eT-NI for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 17:20:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4uAs-0004xN-E4 for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 17:20:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40073) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4uAs-0004x7-8L for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 17:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j4uAs-0002Mb-24 for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2020 17:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Feb 2020 22:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39504 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 39504-submit@debbugs.gnu.org id=B39504.15822371839057 (code B ref 39504); Thu, 20 Feb 2020 22:20:02 +0000 Original-Received: (at 39504) by debbugs.gnu.org; 20 Feb 2020 22:19:43 +0000 Original-Received: from localhost ([127.0.0.1]:46046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4uAY-0002M0-Rm for submit@debbugs.gnu.org; Thu, 20 Feb 2020 17:19:43 -0500 Original-Received: from mail-wm1-f65.google.com ([209.85.128.65]:52469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4uAW-0002Ln-QJ for 39504@debbugs.gnu.org; Thu, 20 Feb 2020 17:19:41 -0500 Original-Received: by mail-wm1-f65.google.com with SMTP id p9so212444wmc.2 for <39504@debbugs.gnu.org>; Thu, 20 Feb 2020 14:19:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=bYQO0H8Jy/kzLKgSLcWXLk1fURpv6UhUrs8r1vAd5wA=; b=k9rqM4pUGhNfRqYOKXoZoTSODk/nI8qz+IZJM/yhlC8RSVQASuYBou49sx3u/QZV1B nA4/ScXOTEzh2fAMMZMJhHGLubRRgboNvUaSpqnYzn/V7fzlh8+QOJA8XK5+WcNpJoZs NFKBpV0MTSVpNdmccb293oD1Fr2KhJcg0tLOdq+SHbrRTNU8S71/M0mmqo8bRQn7S4cK wMiUgP/i08Hsnc2Nn8pvLU2kBrayeBikAGTgD/2X3wuHdqTJ8tMDouJzY23VwRf6xM9O UWkO7UEaSY079ibc6nSybeRVawvLEDXDOYbQKy/1ulyFQrnqWxlkwiJfvAdzT9LQWqqv Su7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=bYQO0H8Jy/kzLKgSLcWXLk1fURpv6UhUrs8r1vAd5wA=; b=ZFR2JwmEgPulWrHTTVwGqVmdUlCKvTT6XLfZH009OfHyEF7kmNnuYm3bKQNDqrUWK4 LOcH6DS1YKUpu7xUcqTGib0/Ae0L6G0VOLGGUX5obK2yiQvoLuv7u+zHp2w14tCOfuFi SeOEn0nYweslZjcWcrIAG0pmWylAsiTWtXEnXICm8ngWTOaz1sUIE64xFcdHNltnI8ZC xxyXIYvE0q0HArPJe/fN5bb12ZlHdFfN+pxPYIQ5EQU21hw8rhnz9za5QqK9D2NXJPaQ +u/23Oq7sXOq2oF4AEvi1YgL+fxwiy/OgT+tYbJmf+02KlBmGTHl/rQQDkpUuk+YURSo BxwQ== X-Gm-Message-State: APjAAAUoZ3S23YBiv+5bUcJUym35EbMbKWXW1TLAkDYcpPXAafzXjuG6 MLPHaDkG8bGhi6IrPjstk8kzo0Y1 X-Google-Smtp-Source: APXvYqxGiUIGxoXseMu1Mz8nO1inMwOny8iA5po3MlSsB0SUIGm7Igz9ECMGaYmujBct0hP3skW6tg== X-Received: by 2002:a7b:c7c9:: with SMTP id z9mr6892445wmk.175.1582237174432; Thu, 20 Feb 2020 14:19:34 -0800 (PST) Original-Received: from hirondell (2a01cb040b29800010fe1ea6b513589a.ipv6.abo.wanadoo.fr. [2a01:cb04:b29:8000:10fe:1ea6:b513:589a]) by smtp.gmail.com with ESMTPSA id z10sm902071wmk.31.2020.02.20.14.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 14:19:33 -0800 (PST) In-Reply-To: <87eeup5qru.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 20 Feb 2020 14:31:33 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176317 Archived-At: Lars Ingebrigtsen writes: > Thanks; applied to Emacs 28. Thanks Lars! Just to be sure, are we fine with how things look on emacs-27? I'm not saying the situation there is unacceptable or anything; I'm just wondering if we're comfortable with the behaviour change between 26 and 27 (cf. screenshots in the opening message). It's a mostly cosmetic issue anyway. Speaking of cosmetic issues, how did you apply my patch? AFAICT you used - my first patch's diff, - my second patch's title, - your own changelog entry. Was there something unsatisfactory with my changelog entry? I don't care much either way, but I'm trying to tick as many boxes as I can to take some load off the maintainers's shoulders; if you'd rather I just dump a plain old diff, I might as well not bother with the changelog. (Also, the second patch's title, "Introduce face for elements", refers to a new face introduced by the patch; the *first* patch does *not* introduce a new face, which is why I gave it a different title. Again, no biggy, it simply makes me question whether I should bother with changelog entries.) I actually thought committing a contributor's patch would be as simple as running "git am" on the attached file, but I now notice that when I download my patches using either Gnus's gnus-mime-save-part or , they contain a stray '>' character on the first line. (I have no idea what causes this; C-u g on the article also shows this stray '>' char, which makes me think that it might have been added while sending? It definitely wasn't there when I created the patches with "git format-patch".) The point being that "git am" chokes on this extra '>', unless given "--patch-format=mbox". (Downloading the attachments from works fine FWIW.) I know you are all pretty busy, I apologize if this falls into nitpicking territory. I'm just slightly embarrassed about the final commit title, and confused about whether the changelog entries I wrote were correct.