From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 39504@debbugs.gnu.org
Subject: bug#39504: 27.0.60; [PATCH] eww/shr: Ensure faces of enclosing elements apply to <code> elements
Date: Thu, 20 Feb 2020 23:19:32 +0100 [thread overview]
Message-ID: <87wo8gsxzf.fsf@gmail.com> (raw)
In-Reply-To: <87eeup5qru.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 20 Feb 2020 14:31:33 +0100")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Thanks; applied to Emacs 28.
Thanks Lars!
Just to be sure, are we fine with how things look on emacs-27? I'm not
saying the situation there is unacceptable or anything; I'm just
wondering if we're comfortable with the behaviour change between 26 and
27 (cf. screenshots in the opening message). It's a mostly cosmetic
issue anyway.
Speaking of cosmetic issues, how did you apply my patch? AFAICT you
used
- my first patch's diff,
- my second patch's title,
- your own changelog entry.
Was there something unsatisfactory with my changelog entry? I don't
care much either way, but I'm trying to tick as many boxes as I can to
take some load off the maintainers's shoulders; if you'd rather I just
dump a plain old diff, I might as well not bother with the changelog.
(Also, the second patch's title, "Introduce face for <code> elements",
refers to a new face introduced by the patch; the *first* patch does
*not* introduce a new face, which is why I gave it a different title.
Again, no biggy, it simply makes me question whether I should bother
with changelog entries.)
I actually thought committing a contributor's patch would be as simple
as running "git am" on the attached file, but I now notice that when I
download my patches using either Gnus's gnus-mime-save-part or
<https://lists.gnu.org/archive/html/bug-gnu-emacs>, they contain a stray
'>' character on the first line.
(I have no idea what causes this; C-u g on the article also shows this
stray '>' char, which makes me think that it might have been added while
sending? It definitely wasn't there when I created the patches with
"git format-patch".)
The point being that "git am" chokes on this extra '>', unless given
"--patch-format=mbox".
(Downloading the attachments from <https://debbugs.gnu.org/39504> works
fine FWIW.)
I know you are all pretty busy, I apologize if this falls into
nitpicking territory. I'm just slightly embarrassed about the final
commit title, and confused about whether the changelog entries I wrote
were correct.
next prev parent reply other threads:[~2020-02-20 22:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 0:06 bug#39504: 27.0.60; [PATCH] eww/shr: Ensure faces of enclosing elements apply to <code> elements Kévin Le Gouguec
2020-02-08 0:17 ` Kévin Le Gouguec
2020-02-20 13:31 ` Lars Ingebrigtsen
2020-02-20 22:19 ` Kévin Le Gouguec [this message]
2020-02-21 12:46 ` Lars Ingebrigtsen
2020-02-21 18:46 ` Kévin Le Gouguec
2020-02-26 14:06 ` Robert Pluim
2020-03-14 12:34 ` Lars Ingebrigtsen
2020-03-14 14:15 ` Kévin Le Gouguec
2020-04-02 11:00 ` Lars Ingebrigtsen
2020-04-03 8:25 ` Kévin Le Gouguec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo8gsxzf.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=39504@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.