[PATCH] Do not ignore org-odt-styles-file

[PATCH] Do not ignore org-odt-styles-file

[Eric Timmons]

:odt-styles-file was duplicated in ox-odt's org-export-define-backend
form. This lead to the org-odt-styles-file custom being completely ignored.
---
 lisp/ox-odt.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/ox-odt.el b/lisp/ox-odt.el
index 2723c60c9..d353a3a2e 100644
--- a/lisp/ox-odt.el
+++ b/lisp/ox-odt.el
@@ -96,7 +96,7 @@
 	      (if a (org-odt-export-to-odt t s v)
 		(org-open-file (org-odt-export-to-odt nil s v) 'system))))))
   :options-alist
-  '((:odt-styles-file "ODT_STYLES_FILE" nil nil t)
+  '((:odt-styles-file "ODT_STYLES_FILE" nil org-odt-styles-file t)
     (:description "DESCRIPTION" nil nil newline)
     (:keywords "KEYWORDS" nil nil space)
     (:subtitle "SUBTITLE" nil nil parse)
@@ -110,7 +110,6 @@
     (:odt-inline-formula-rules nil nil org-odt-inline-formula-rules)
     (:odt-inline-image-rules nil nil org-odt-inline-image-rules)
     (:odt-pixels-per-inch nil nil org-odt-pixels-per-inch)
-    (:odt-styles-file nil nil org-odt-styles-file)
     (:odt-table-styles nil nil org-odt-table-styles)
     (:odt-use-date-fields nil nil org-odt-use-date-fields)
     ;; Redefine regular option.
-- 
2.25.1

Re: [PATCH] Do not ignore org-odt-styles-file

[Kyle Meyer]

Thanks for the patch.

Eric Timmons <etimmons@mit.edu> writes:

> :odt-styles-file was duplicated in ox-odt's org-export-define-backend
> form. This lead to the org-odt-styles-file custom being completely ignored.

That change looks good, and, while I'm not an ox-odt user, light testing
on my end confirms the issue and fix.

Could you update your patch to follow the conventions outlined at
<https://orgmode.org/worg/org-contribute.html>?  In particular, add (1)
a change-log entry to the commit message and (2) a TINYCHANGE cookie.
Also, it's typical for commit subjects in this project to start with
"<area or file>: ...".

Re: [PATCH] Do not ignore org-odt-styles-file

[Kyle Meyer]

Kyle Meyer writes:

> Could you update your patch to follow the conventions outlined at
> <https://orgmode.org/worg/org-contribute.html>?  In particular, add (1)
> a change-log entry to the commit message and (2) a TINYCHANGE cookie.
> Also, it's typical for commit subjects in this project to start with
> "<area or file>: ...".


I've tweaked the commit message and applied it (0f783cbca).