* bug#41095: ERC header line
@ 2020-05-05 12:46 Philip K.
2020-07-29 4:54 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Philip K. @ 2020-05-05 12:46 UTC (permalink / raw)
To: 41095
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
Hi,
when trying out a dark theme I noticed that the ERC header line was out
of place. It turns out that this is because it's fore- and background
color are hard-coded to gray20 and gray90. Since these are fairly
similar to the default colours of header-line using a light
colour-scheme, I suggest inheriting it's values by default.c
--
Philip K.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Make-erc-header-line-inherit-from-header-line.patch --]
[-- Type: text/x-diff, Size: 710 bytes --]
From e5083ec06ee6a2be637fb8773a9c6cd907b26fc5 Mon Sep 17 00:00:00 2001
From: Philip K <philip@warpmail.net>
Date: Tue, 5 May 2020 14:41:06 +0200
Subject: [PATCH] Make erc-header-line inherit from header-line
---
lisp/erc/erc.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index cfde84e19a..a237ca7ce9 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -1212,7 +1212,7 @@ erc-direct-msg-face
:group 'erc-faces)
(defface erc-header-line
- '((t :foreground "grey20" :background "grey90"))
+ '((t :inherit header-line))
"ERC face used for the header line.
This will only be used if `erc-header-line-face-method' is non-nil."
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#41095: ERC header line
2020-05-05 12:46 bug#41095: ERC header line Philip K.
@ 2020-07-29 4:54 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2020-07-29 4:54 UTC (permalink / raw)
To: Philip K.; +Cc: 41095
philip@warpmail.net (Philip K.) writes:
> when trying out a dark theme I noticed that the ERC header line was out
> of place. It turns out that this is because it's fore- and background
> color are hard-coded to gray20 and gray90. Since these are fairly
> similar to the default colours of header-line using a light
> colour-scheme, I suggest inheriting it's values by default.c
[...]
> (defface erc-header-line
> - '((t :foreground "grey20" :background "grey90"))
> + '((t :inherit header-line))
> "ERC face used for the header line.
This also makes the header line look less awkward in dark mode, so it
makes sense to me. Applied to Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-29 4:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-05 12:46 bug#41095: ERC header line Philip K.
2020-07-29 4:54 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.