From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: philip@warpmail.net (Philip K.) Newsgroups: gmane.emacs.bugs Subject: bug#41095: ERC header line Date: Tue, 05 May 2020 14:46:47 +0200 Message-ID: <87wo5q1rd4.fsf@bulbul> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="900"; mail-complaints-to="usenet@ciao.gmane.io" To: 41095@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 05 14:47:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jVwyb-000066-Rq for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 May 2020 14:47:10 +0200 Original-Received: from localhost ([::1]:38708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVwya-0001h0-Tg for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 May 2020 08:47:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVwyU-0001gg-F4 for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 08:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51726) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVwyU-0007NM-5e for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 08:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jVwyU-0005YR-4c for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 08:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: philip@warpmail.net (Philip K.) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 May 2020 12:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 41095 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.158868281821340 (code B ref -1); Tue, 05 May 2020 12:47:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 May 2020 12:46:58 +0000 Original-Received: from localhost ([127.0.0.1]:35039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVwyQ-0005Y8-Gi for submit@debbugs.gnu.org; Tue, 05 May 2020 08:46:58 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:43976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVwyO-0005Y0-Pn for submit@debbugs.gnu.org; Tue, 05 May 2020 08:46:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVwyO-0001gK-GI for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 08:46:56 -0400 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:44129) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVwyM-0007M1-9N for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 08:46:56 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id ABD42751 for ; Tue, 5 May 2020 08:46:50 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 05 May 2020 08:46:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=warpmail.net; h= from:to:subject:date:message-id:mime-version:content-type; s= fm3; bh=98RrR9+LNl7HeH2lGnJUwfyRrMk/ZYDd/9zA8aLpEck=; b=NR3iKNMY xkeAqlH4J1x+a2SkkMYuGQr2ZKYazcr2Ls0MzYg2j6xnlJwgkKFGr8gq07oM9Mzs onuLgESloUUPSxuegnRIgkeMVgX56w6vnAEvGaB6O9cfORjxRd4CcjljuoPbynnc O7zkbgEB9it0o1ARhlHR4bOONmsajUncbbjwwFQRhfMOowlNzuImZHSxhbf0RKG9 +PLokASrnSTwu7aHCZ1Fgv0k/JJiKdY5oe7JMTPyKHtrPWhBplXdNIwD626Wlz42 XNIqk0V0EZu84ldB4rNsbYf4bxmNdINX/ddM7wLvMu5CIgmcP08fIjoBue217A/P AuMlnj7Fr+ZdOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=98RrR9+LNl7HeH2lGnJUwfyRrMk/Z YDd/9zA8aLpEck=; b=QUm3H9OECfmVAhroYexVzeSS/140Db7WxVpFWPNihPWXm wpVVwtqHlqMN1/avJ1G89efGrotQlse8HpbHZD7W0d64TER6zwlt1i526ngH0hhJ VT4Hceu8HW6x61LcDgVSjS4+MzTx3t62Vlzsjvd5FkpMz90IbQL5L9UDGQu6Y9c2 GRmKu5KC65zEa47Flr8dttlEohghDX3k2BJfRRRqm03eOrnoFK1jlhmGrZdhjNW4 ZUcgHrmGtcpHJHuUrX/HuOpbkZVOM6HyJ2jM+BZfesSQ98ZoWi8Drfeoehcy/taj zp4tqUs6v6yzfvFgKyaKTKvSjE8DqnrQl8ENpThCw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrjeeigdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfggtgesmhdtreertddttd enucfhrhhomhepphhhihhlihhpseifrghrphhmrghilhdrnhgvthculdfrhhhilhhiphcu mfdrmdenucggtffrrghtthgvrhhnpefhfefhuedvleejiedttdevveejvdfgkefgtdffke fhjefgfeelieehgffffeevkeenucfkphepkeejrddugeehrdelrdejnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphhhihhlihhpseifrghrph hmrghilhdrnhgvth X-ME-Proxy: Original-Received: from localhost (p57910907.dip0.t-ipconnect.de [87.145.9.7]) by mail.messagingengine.com (Postfix) with ESMTPA id D1D863066012 for ; Tue, 5 May 2020 08:46:49 -0400 (EDT) Received-SPF: pass client-ip=64.147.123.20; envelope-from=philip@warpmail.net; helo=wout4-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/05 08:46:51 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179730 Archived-At: --=-=-= Content-Type: text/plain Hi, when trying out a dark theme I noticed that the ERC header line was out of place. It turns out that this is because it's fore- and background color are hard-coded to gray20 and gray90. Since these are fairly similar to the default colours of header-line using a light colour-scheme, I suggest inheriting it's values by default.c -- Philip K. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Make-erc-header-line-inherit-from-header-line.patch >From e5083ec06ee6a2be637fb8773a9c6cd907b26fc5 Mon Sep 17 00:00:00 2001 From: Philip K Date: Tue, 5 May 2020 14:41:06 +0200 Subject: [PATCH] Make erc-header-line inherit from header-line --- lisp/erc/erc.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index cfde84e19a..a237ca7ce9 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -1212,7 +1212,7 @@ erc-direct-msg-face :group 'erc-faces) (defface erc-header-line - '((t :foreground "grey20" :background "grey90")) + '((t :inherit header-line)) "ERC face used for the header line. This will only be used if `erc-header-line-face-method' is non-nil." -- 2.20.1 --=-=-=--