From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= Newsgroups: gmane.emacs.orgmode,gmane.emacs.devel Subject: Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode Date: Thu, 07 May 2020 14:03:10 +0200 Message-ID: <87wo5ogdfl.fsf@gmail.com> References: <20200426172206.GC18629@ACM> <87y2qhnc9a.fsf@gmail.com> <20200427102311.GA4976@ACM> <87mu6xtano.fsf@gmail.com> <87k120ohsq.fsf@mail.linkov.net> <87blnbir01.fsf@nicolasgoaziou.fr> <87o8rbmbfa.fsf@mail.linkov.net> <87k11yftqo.fsf@nicolasgoaziou.fr> <87pnbqo74t.fsf_-_@gmail.com> <87ees6fp8r.fsf@nicolasgoaziou.fr> <87y2q89dx7.fsf@gmail.com> <874ksv4uv1.fsf@nicolasgoaziou.fr> <87ftcfekxt.fsf@gmail.com> <877dxpazbo.fsf_-_@gmail.com> <87ftcc9g27.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="108917"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Emacs developers To: Org Mode list Original-X-From: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Thu May 07 14:05:22 2020 Return-path: Envelope-to: geo-emacs-orgmode@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWfHG-000SDJ-6l for geo-emacs-orgmode@m.gmane-mx.org; Thu, 07 May 2020 14:05:22 +0200 Original-Received: from localhost ([::1]:48434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWfHF-00048d-6H for geo-emacs-orgmode@m.gmane-mx.org; Thu, 07 May 2020 08:05:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWfFI-0002mU-Ae; Thu, 07 May 2020 08:03:21 -0400 Original-Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:42391) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWfFE-0005oV-3z; Thu, 07 May 2020 08:03:19 -0400 Original-Received: by mail-wr1-x441.google.com with SMTP id s8so6065860wrt.9; Thu, 07 May 2020 05:03:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=y2QLf4H3sf60LKXPITzr9hHWzDZcbuJTYtgiA5TVhcs=; b=Acxa/QamFr/pG1Jz2IGGA8LUwjGa0Le5hem5C7/qzx4ebJh/qIcb2XWjmlf28I92CG EtTUiFZ/k0TwI/lk2Ims0MGPt1f8gRzvVFbHCvC5H0elWC9U99Zb/sc5bNlUB+SSIVVG 9vNKy7/9EJqHLFOLjEx4/pYNH0DhT0eOATN72z3VeLLFegtmJyBRHq11WfQC+gO6VfDK J/4tXMo54pgfeHvvYkDVaQXWGh1e9kRuOekOzouKoCbkWymb3yIGmnREnO6P4KFAsfz8 LP5qfE248QhPghFgWtv9SS1+AYx7n/9sPYhgj0PUcfCfRP/MYmw04N0yOPeXGG3kIL9U 1nzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=y2QLf4H3sf60LKXPITzr9hHWzDZcbuJTYtgiA5TVhcs=; b=Ol/5U7H5hyMtCUBTQYcTE3kby/Ir/XvI1ae2O1KWjgHzrqRyyf680BbOWiXzbxBETD 2Xf9CHgU1EhQ2bxuareUXywGP9hjBV5GQn51ic5Zbq2Bucr+WtovaYG4NoG5U2H4UniX L7UfYJb9hti2kLjDtu5ZxHqOIB534UM/Zi+MskZD7p7k0PMnq+vkea8mUsdnEShs63KV 5NYQFDTEkbok2QZjK82+vYrJhdrr0N9YnQgEx1HW1Sn0CZbka+SkdK3RWxVvnJVr6dzj nxS3G2WvFkxQ5J6K9a55X1QboZswa84LqDUZ1+pYGlKuZVSpzLwUKrUBbz+bjZFZpqu/ mmOA== X-Gm-Message-State: AGi0PubSjw01wRGjYW3/rH65ASobg2JD8g62M9+btzGZSJfZMf4Ii4LM DKNjQ8RBMDgC8NUzytp3ZFQiYJgBQjXYgw== X-Google-Smtp-Source: APiQypKJJrnt/FtxOQRlATxb3lSrMs+JBCA0El6Z8pKMCMAmaX6bNTSTKGnaJfE3qy/ZfoBK8l9tGQ== X-Received: by 2002:a5d:4685:: with SMTP id u5mr14152525wrq.98.1588852992864; Thu, 07 May 2020 05:03:12 -0700 (PDT) Original-Received: from my-little-tumbleweed (200.143.13.109.rev.sfr.net. [109.13.143.200]) by smtp.gmail.com with ESMTPSA id t71sm8095445wmt.31.2020.05.07.05.03.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 05:03:11 -0700 (PDT) In-Reply-To: <87ftcc9g27.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Thu, 07 May 2020 12:48:16 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::441; envelope-from=kevin.legouguec@gmail.com; helo=mail-wr1-x441.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-orgmode" Xref: news.gmane.io gmane.emacs.orgmode:128902 gmane.emacs.devel:249162 Archived-At: Nicolas Goaziou writes: > I fixed a typo and applied your patch. Thank you for fixing the typo in ORG-NEWS. I see you've removed ARG from the call to `newline-and-indent'; I don't have a strong opinion about this (though I don't see a reason not to keep it), but I guess the docstring of `org--newline' should be changed to match? > However, when I have to reproduce a failing test, I don't even want to > think about the recipe and rather concentrate on the results. Hence, > I expect `should' macro's body to be self-sufficient. Therefore, > I skipped this part of the patch. Fair enough; toggling the local variant of the minor mode is probably cleaner anyway! Thanks for the review, and for applying.