all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: Org Mode <emacs-orgmode@gnu.org>, John Kitchin <jkitchin@andrew.cmu.edu>
Subject: Re: [QUESTION] What's the ":desk" link parameter?
Date: Sun, 24 May 2020 19:34:43 +0800	[thread overview]
Message-ID: <87wo51o9bg.fsf@localhost> (raw)
In-Reply-To: <871rn9wqat.fsf@gnu.org>

> thanks for the patch.  I assume you are submitting it against master,
> am I right?

The patch is against commit 2e96dc639. 

> From reading this, I don't see what bug it fixes, what problem it
> solves or what real user need it responds to, but maybe I lost part
> of the context.  Can you explain why this should be applied?

It does not fix any bug. Rather adds a new feature [1]. Currently, org
provides org-link-make-description-function as user customisation to
compute default link description. The patch provides a way to set such
description functions on per link type basis (via :description link
parameter). Using link parameters looks natural for me since similar
customisation is already done in :follow and :store link parameters.

[1] https://lists.gnu.org/archive/html/emacs-orgmode/2019-08/msg00013.html

Best,
Ihor

Bastien <bzg@gnu.org> writes:

> Hi Ihor,
>
> thanks for the patch.  I assume you are submitting it against master,
> am I right?
>
> Ihor Radchenko <yantar92@gmail.com> writes:
>
>> +`:description'
>> +
>> +  Function to use for generating link descriptions from links.  This
>> +  function must take two parameters: the first one is the link, the
>> +  second one is the description generated by `org-insert-link'.  The
>> +  function should return the description to use.
>
> From reading this, I don't see what bug it fixes, what problem it
> solves or what real user need it responds to, but maybe I lost part
> of the context.  Can you explain why this should be applied?
>
> Thanks,
>
> -- 
>  Bastien

-- 
Ihor Radchenko,
PhD,
Center for Advancing Materials Performance from the Nanoscale (CAMP-nano)
State Key Laboratory for Mechanical Behavior of Materials, Xi'an Jiaotong University, Xi'an, China
Email: yantar92@gmail.com, ihor_radchenko@alumni.sutd.edu.sg


  reply	other threads:[~2020-05-24 11:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-23 12:23 [QUESTION] What's the ":desk" link parameter? stardiviner
2020-05-23 13:49 ` Bastien
2020-05-23 14:01 ` John Kitchin
2020-05-23 23:52   ` stardiviner
2020-05-24  3:10     ` Ihor Radchenko
2020-05-24 11:00       ` Bastien
2020-05-24 11:34         ` Ihor Radchenko [this message]
2020-06-02 12:29           ` Bastien
2020-06-02 13:22             ` Ihor Radchenko
2020-06-02 13:55               ` stardiviner
2020-05-24 11:12       ` stardiviner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wo51o9bg.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=jkitchin@andrew.cmu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.