"Basil L. Contovounesios" writes: > Eli Zaretskii writes: >>> From: Pip Cet >>> Date: Thu, 04 Jun 2020 09:35:12 +0000 >>> >>> ./emacs -Q >>> enter: C-x C-f * / * >>> >>> expected result: a list of sub-subdirectories of the emacs src dir. A >>> "Find file: .../emacs/src/*/" prompt. >>> >>> actual result: prompt says "Find file: .../emacs/src//", further tab >>> completion uses the root directory. >>> >>> I'd noticed this for a while now, but thought it was a local >>> configuration issue. It happens in emacs -Q, too, though. >>> >>> For master, we should fix minibuffer.el properly, but I'm not sure what >>> to do on emacs-27. It's a regression (from Emacs 26) that might annoy >>> many users of tab completion in the minibuffer. >> >> Can you bisect to find which commit broke this? > > I selectively applied commits onto emacs-26 rather than bisecting, and > it seems to point to [1]. Paging Stefan. Thanks for that! I'd actually suspected the same file as well, and started playing around with the code a little. I'm suspicious of the code in completion-pcm--optimize-pattern which turns a '(star) pattern into nil. That's correct as far as which strings qualify as matches, but it's incorrect because it doesn't survive the completion-pcm--pattern->string round trip. I think we get something closer to Emacs-26 behavior back with this patch.