From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 41974@debbugs.gnu.org
Subject: bug#41974: 28.0.50; Some vc commands refuse to work when called on non-file buffer
Date: Mon, 22 Jun 2020 01:51:20 +0300 [thread overview]
Message-ID: <87wo40ghht.fsf@mail.linkov.net> (raw)
In-Reply-To: <dbcb5355-249b-10df-0efd-96606b841176@yandex.ru> (Dmitry Gutov's message of "Sun, 21 Jun 2020 03:07:40 +0300")
> On 21.06.2020 02:55, Juri Linkov wrote:
>> I think this restriction should be lifted, so vc commands should
>> work even when called on non-file buffers whose default-directory
>> is inside the vc project.
>
> Agreed.
>
> Does this patch help, or does it miss more cases?
>
> diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
> index 9b12d44978..36013fcdc9 100644
> --- a/lisp/vc/vc.el
> +++ b/lisp/vc/vc.el
> @@ -2563,7 +2563,7 @@ vc-print-branch-log
> (vc-read-revision "Branch to log: ")))
> (when (equal branch "")
> (error "No branch specified"))
> - (let* ((backend (vc-responsible-backend default-directory))
> + (let* ((backend (vc-deduce-backend))
> (rootdir (vc-call-backend backend 'root default-directory)))
> (vc-print-log-internal backend
> (list rootdir) branch t
Strange, this patch has no effect, the same error remains.
next prev parent reply other threads:[~2020-06-21 22:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 23:55 bug#41974: 28.0.50; Some vc commands refuse to work when called on non-file buffer Juri Linkov
2020-06-21 0:07 ` Dmitry Gutov
2020-06-21 22:51 ` Juri Linkov [this message]
2020-06-22 0:59 ` Dmitry Gutov
2020-06-22 23:38 ` Juri Linkov
2020-06-23 0:34 ` Dmitry Gutov
2020-06-23 23:54 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo40ghht.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=41974@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.