From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#38707: dired-do-rename doesn't check for "/" ! Date: Thu, 06 Aug 2020 12:13:48 +0200 Message-ID: <87wo2cdqub.fsf@gnus.org> References: <87d0cge2pl.5.fsf@jidanni.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8716"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 38707@debbugs.gnu.org To: Nick Helm Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 06 12:15:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k3cvV-00027d-Sd for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Aug 2020 12:15:09 +0200 Original-Received: from localhost ([::1]:59488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3cvU-0004Uw-VB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Aug 2020 06:15:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3cvO-0004UZ-28 for bug-gnu-emacs@gnu.org; Thu, 06 Aug 2020 06:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41659) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k3cvN-0003UX-Ov for bug-gnu-emacs@gnu.org; Thu, 06 Aug 2020 06:15:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k3cvN-0005kp-K3 for bug-gnu-emacs@gnu.org; Thu, 06 Aug 2020 06:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Aug 2020 10:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38707 X-GNU-PR-Package: emacs Original-Received: via spool by 38707-submit@debbugs.gnu.org id=B38707.159670884622028 (code B ref 38707); Thu, 06 Aug 2020 10:15:01 +0000 Original-Received: (at 38707) by debbugs.gnu.org; 6 Aug 2020 10:14:06 +0000 Original-Received: from localhost ([127.0.0.1]:53202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3cuT-0005jE-VA for submit@debbugs.gnu.org; Thu, 06 Aug 2020 06:14:06 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:52040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3cuS-0005iX-89 for 38707@debbugs.gnu.org; Thu, 06 Aug 2020 06:14:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SJZtuZnCyN2BZArK5tmw2Qi79zYC7DGXZco3EcWovj0=; b=gM6C9GK24iYGU05Oc6wyxWMVVr u03aXDFgCgibvmHC/dphr0ZRVueoLR5qqvI5P1UaMCN6b51r6q3cbgJZjkMfY1HIlJzciuuI6O6X7 PMfYI9lIJsvkm8fRTuuC4Sr0p4mgcISvISV9AOPhE0KwWRjVw1lRkmIB+LjtDA6bEcgc=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k3cuD-00008F-Bb; Thu, 06 Aug 2020 12:13:57 +0200 In-Reply-To: (Nick Helm's message of "Tue, 24 Dec 2019 17:28:55 +1300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184168 Archived-At: Nick Helm writes: > Dired could check for and issue an error in the case where the source is > a file and the target appears to be a non-existent directory. Something > like this perhaps? [...] > + (if (and (not (file-directory-p (car fn-list))) > + (not (file-directory-p target)) > + (directory-name-p target)) > + (error "%s: Target directory does not exist: %s" operation target)) I think this makes sense, so I've applied it to Emacs 28.1. However, it is a slight behavioural change -- previously you could enter, say "/tmp/bar/" (when moving one file), and it would move the file to the file "/tmp/bar". I think the new behaviour is better (i.e., bugging out), but if people complain for some reason, then it should perhaps be reverted. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no