From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#35014: speedbar-expand-line-descendants opens non-descendant tree entries Date: Wed, 19 Aug 2020 12:46:17 +0200 Message-ID: <87wo1u7w1y.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22912"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 35013@debbugs.gnu.org, 35014@debbugs.gnu.org To: Kieran Barry Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 19 12:47:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8Lce-0005r0-8Z for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Aug 2020 12:47:12 +0200 Original-Received: from localhost ([::1]:49840 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8Lcd-0003dW-6f for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Aug 2020 06:47:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8LcU-0003bq-Qx for bug-gnu-emacs@gnu.org; Wed, 19 Aug 2020 06:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54698) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k8LcU-0003Vn-G7 for bug-gnu-emacs@gnu.org; Wed, 19 Aug 2020 06:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k8LcU-0006eC-Ex for bug-gnu-emacs@gnu.org; Wed, 19 Aug 2020 06:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Aug 2020 10:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35014 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35014-submit@debbugs.gnu.org id=B35014.159783399325466 (code B ref 35014); Wed, 19 Aug 2020 10:47:02 +0000 Original-Received: (at 35014) by debbugs.gnu.org; 19 Aug 2020 10:46:33 +0000 Original-Received: from localhost ([127.0.0.1]:37999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8Lc0-0006ca-UK for submit@debbugs.gnu.org; Wed, 19 Aug 2020 06:46:33 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:43224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8Lbw-0006cA-89; Wed, 19 Aug 2020 06:46:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=54c4jbeMe5Y01i19xD6nnUIsPZAMwYd0lZ4lnlXYDR0=; b=s5J1HPOZXc2UGXRwjML38xWovS c1v2GLCH25e+A1tBBgcvaiSz9AwzcvUs8HLNv2tFQ5hxq4FMkwddIieNDXAqkr2yoZYp0TXakg6hV XsxKN8au2MdnvpWDFd9/nVVVeFHXgWBw7VO6+kNgwMnZ16sJ+EZucXG7Z4P0kgn8F9ak=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8Lbn-0003hl-7k; Wed, 19 Aug 2020 12:46:21 +0200 X-Now-Playing: Various's _Lonely is an Eyesore_: "Dif Juz - No Motion" In-Reply-To: (Kieran Barry's message of "Tue, 26 Mar 2019 20:55:51 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185568 Archived-At: Kieran Barry writes: > Patch to fix. > > Changelog: > 2019-03-26 Kieran Barry > * lisp/speedbar.el: speedbar-expand-line-descendants fixed to only expand > descendants of current node. Thanks for the patch. I had a look at the speedbar code (I don't normally use the mode myself), and there seemed like a much simpler fix -- just narrow to the current line before starting to expand. I tried that, and it seems to work for me, so I've pushed that fix to Emacs 28 instead. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no