From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#8897: `completion--insert-strings' clobbers user-added text properties Date: Mon, 14 Sep 2020 14:25:02 +0200 Message-ID: <87wo0wbl5t.fsf@gnus.org> References: <8739j5bs01.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10002"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 8897@debbugs.gnu.org To: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 14 14:26:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHnYf-0002T9-Sk for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Sep 2020 14:26:09 +0200 Original-Received: from localhost ([::1]:46768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHnYe-0007XT-QP for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Sep 2020 08:26:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHnYY-0007UW-7L for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2020 08:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41420) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHnYX-0007hD-Sr for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2020 08:26:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHnYX-0005aS-P7 for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2020 08:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Sep 2020 12:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8897 X-GNU-PR-Package: emacs Original-Received: via spool by 8897-submit@debbugs.gnu.org id=B8897.160008632021400 (code B ref 8897); Mon, 14 Sep 2020 12:26:01 +0000 Original-Received: (at 8897) by debbugs.gnu.org; 14 Sep 2020 12:25:20 +0000 Original-Received: from localhost ([127.0.0.1]:52962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHnXs-0005Z6-67 for submit@debbugs.gnu.org; Mon, 14 Sep 2020 08:25:20 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:58200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHnXo-0005Yn-Ij for 8897@debbugs.gnu.org; Mon, 14 Sep 2020 08:25:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=B4weKqJ8fgNK8vMz3Wnoz/rNF75/aXpUwcTEcyX0d2o=; b=odkt7X+Y1ekEvTQfGj+jCF6wkg YVCOeE//BQdty76iWRRO/BWsw4C1aCvy0uUrxFJYr1TqEeLDLa7gx0eYLZkhaCsyTysHn5KBKuefJ jR3d3fdUxKkcFFoWh68tn2MTGITvC/jpDTpIM5K11Up0676qcvuxhyZK7oGbagu3Rmak=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHnXb-0001JK-M9; Mon, 14 Sep 2020 14:25:10 +0200 X-Now-Playing: Cosey Fanni Tutti's _Tutti_: "Drone" In-Reply-To: <8739j5bs01.fsf@gmail.com> ("=?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?="'s message of "Sun, 19 Jun 2011 20:22:54 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188039 Archived-At: =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec writes: > It is possible to bind `completion-annotate-function' to add custom > annotations, which is great. Unfortunately, the `face' and `mouse-face' > text properties added by such a function are then unconditionally > overwritten by `completion--insert-strings'. > > In my particular case I define annotations as buttons (which display > even more detail about a completion value upon activation), so a visual > indication of clickability is very important for me. > > I wonder if something like the patch below, which fixes the problem for > me, could be applied? In conjunction with bug#43218, completion no longer clobbers all text properties (but it does clobber the face text property). So it still requires some wrangling by the caller if the text property was the one they wanted to have preserved, but the caller can stash that in a different text property. This requires that `minibuffer-allow-text-properties' is non-nil. So I think that basically takes care of the problem described here, and I'm closing this bug report.=20=20 --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no