bug#43742: Unable to compile ada-mode

bug#43742: Unable to compile ada-mode

[Colton Lewis via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Package: emacs, ada-mode

I have recently tried and failed to compile ada-mode.
This may be a bug in -gnat2020 support, but I'm not
sure how the list wants to handle a solution.

emacs-27.1
ada-mode-7.1.4
gnat-10.2.1

$ ./build.sh
...
gen_run_wisi_lr_parse.ads:27:52: missing ";"
gen_run_wisi_lr_parse.ads:27:65: generic private child packages not permitted
gen_run_wisi_lr_parse.ads:27:65: subprogram specification expected
gen_run_wisi_lr_parse.ads:27:65: compilation unit expected
gen_run_wisi_lr_parse.ads:34:04: misplaced "with"
gen_run_wisi_lr_parse.ads:34:09: reserved word "procedure" cannot be used as identifier
gen_run_wisi_lr_parse.ads:34:18: missing ";"
gen_run_wisi_lr_parse.ads:34:19: compilation unit expected
clang-10: error: argument unused during compilation: '-specs=/tmp/GNAT-TEMP-000012.TMP' [-Werror,-Wunused-command-line-argument]

   compilation of ada_mode_wisi_lalr_parse.ads failed
   compilation of ada_mode_wisi_lr1_parse.ads failed
   compilation of run_ada_lalr_parse.ads failed
   compilation of run_ada_lr1_parse.ads failed
   compilation of gpr_mode_wisi_parse.ads failed
   compilation of run_gpr_parse.ads failed
   compilation of wisitoken_grammar_re2c.c failed

gprbuild: *** compilation phase failed

It is choking on the line:
type Parse_Data_Type is new Wisi.Parse_Data_Type with private;

As far as I can tell from the ARM, this should be legal in 2020 and 2012.
Also note the clang error. Trying with some options.

$ ./build -cargs:ada -gnat2012 -cargs:c -Wno-error=unused-command-line-argument
...
Compile
   [Ada]          ada_mode_wisi_lalr_parse.ads
   [Ada]          ada_mode_wisi_lr1_parse.ads
   [Ada]          run_ada_lalr_parse.ads
   [Ada]          run_ada_lr1_parse.ads
   [Ada]          gpr_mode_wisi_parse.ads
   [Ada]          run_gpr_parse.ads
   [Ada]          gpr_query.adb
   [C]            wisitoken_grammar_re2c.c
gpr_query.adb:553:19: target_name is an Ada 2020 feature
gpr_query.adb:553:22: (style) space not allowed
clang-10: warning: argument unused during compilation: '-specs=/tmp/GNAT-TEMP-000012.TMP' [-Wunused-command-line-argument]

   compilation of gpr_query.adb failed

And we fail again lacking a 2020 feature.

bug#43742: Unable to compile ada-mode

[Lars Ingebrigtsen]

Colton Lewis <colton.w.lewis@protonmail.com> writes:

> Package: emacs, ada-mode
>
> I have recently tried and failed to compile ada-mode.
> This may be a bug in -gnat2020 support, but I'm not
> sure how the list wants to handle a solution.
>
> emacs-27.1
> ada-mode-7.1.4
> gnat-10.2.1
>
> $ ./build.sh
> ...
> gen_run_wisi_lr_parse.ads:27:52: missing ";"

I'm not quite sure I understand the bug report.  Is it about compiling
ada-mode, or is it about building gnat?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#43742: Unable to compile ada-mode

[Simon Wright via Bug reports for GNU Emacs, the Swiss army knife of text editors]

GCC 10[.1.0] has the problem.
GCC 9[.1.0] does not.

I haven't bothered to install the necessary gnatcoll packages in GNAT CE 2020 so I don't know whether it would work or fail.

> On 1 Oct 2020, at 05:55, Colton Lewis <colton.w.lewis@protonmail.com> wrote:
> 
> Package: emacs, ada-mode
> 
> I have recently tried and failed to compile ada-mode.
> This may be a bug in -gnat2020 support, but I'm not
> sure how the list wants to handle a solution.
> 
> emacs-27.1
> ada-mode-7.1.4
> gnat-10.2.1
> 
> $ ./build.sh
> ...
> gen_run_wisi_lr_parse.ads:27:52: missing ";"
> gen_run_wisi_lr_parse.ads:27:65: generic private child packages not permitted
> gen_run_wisi_lr_parse.ads:27:65: subprogram specification expected
> gen_run_wisi_lr_parse.ads:27:65: compilation unit expected
> gen_run_wisi_lr_parse.ads:34:04: misplaced "with"
> gen_run_wisi_lr_parse.ads:34:09: reserved word "procedure" cannot be used as identifier
> gen_run_wisi_lr_parse.ads:34:18: missing ";"
> gen_run_wisi_lr_parse.ads:34:19: compilation unit expected
> clang-10: error: argument unused during compilation: '-specs=/tmp/GNAT-TEMP-000012.TMP' [-Werror,-Wunused-command-line-argument]
> 
>   compilation of ada_mode_wisi_lalr_parse.ads failed
>   compilation of ada_mode_wisi_lr1_parse.ads failed
>   compilation of run_ada_lalr_parse.ads failed
>   compilation of run_ada_lr1_parse.ads failed
>   compilation of gpr_mode_wisi_parse.ads failed
>   compilation of run_gpr_parse.ads failed
>   compilation of wisitoken_grammar_re2c.c failed
> 
> gprbuild: *** compilation phase failed
> 
> It is choking on the line:
> type Parse_Data_Type is new Wisi.Parse_Data_Type with private;
> 
> As far as I can tell from the ARM, this should be legal in 2020 and 2012.
> Also note the clang error. Trying with some options.
> 
> $ ./build -cargs:ada -gnat2012 -cargs:c -Wno-error=unused-command-line-argument
> ...
> Compile
>   [Ada]          ada_mode_wisi_lalr_parse.ads
>   [Ada]          ada_mode_wisi_lr1_parse.ads
>   [Ada]          run_ada_lalr_parse.ads
>   [Ada]          run_ada_lr1_parse.ads
>   [Ada]          gpr_mode_wisi_parse.ads
>   [Ada]          run_gpr_parse.ads
>   [Ada]          gpr_query.adb
>   [C]            wisitoken_grammar_re2c.c
> gpr_query.adb:553:19: target_name is an Ada 2020 feature
> gpr_query.adb:553:22: (style) space not allowed
> clang-10: warning: argument unused during compilation: '-specs=/tmp/GNAT-TEMP-000012.TMP' [-Wunused-command-line-argument]
> 
>   compilation of gpr_query.adb failed
> 
> And we fail again lacking a 2020 feature.
> 
> 
> 
> 
> 
> 

bug#43742: Unable to compile ada-mode

[Stephen Leake]

Colton Lewis <colton.w.lewis@protonmail.com> writes:

>
> emacs-27.1
> ada-mode-7.1.4
> gnat-10.2.1

What is "gnat-10.2.1"? where did you get it?

If possible, report this as a compiler bug.

I'm testing with the GNAT Community releases, and a gnat pro wavefront.


> gpr_query.adb:553:19: target_name is an Ada 2020 feature

that line is:

         Count := @ + 1;

you can change it to:

         Count := Count + 1;

-- 
-- Stephe

bug#43742: Unable to compile ada-mode

[Colton Lewis via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On Sunday, October 4, 2020 6:01:10 PM CDT Stephen Leake wrote:
> 
> Colton Lewis <colton.w.lewis@protonmail.com> writes:
> 
> >
> > emacs-27.1
> > ada-mode-7.1.4
> > gnat-10.2.1
> 
> What is "gnat-10.2.1"? where did you get it?

GCC version 10.2.1 from the default Fedora 32 repositories. On a tangent,
the online Emacs manual says ada-mode should be included in the standard
distribution, but it wasn't. Should it be there?

> If possible, report this as a compiler bug.

Done: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97283
Closed as the logic bug causing the issue is fixed on master.
Unsure if it will be released in GCC 10 updates.

> that line is:
> 
>          Count := @ + 1;
> 
> you can change it to:
> 
>          Count := Count + 1;

Thanks. After changing that, I get a further error.

$ ./build.sh -cargs:ada -gnat2012 -cargs:c -Wno-error=unused-command-line-argument
...
   [Ada]          wisi-ada.adb
   [Ada]          wisitoken.adb
sal-gen_unbounded_definite_red_black_trees.adb:308:26: access discriminant in return aggregate would be a dangling reference
sal-gen_unbounded_definite_red_black_trees.adb:326:29: access discriminant in return aggregate would be a dangling reference
sal-gen_unbounded_definite_red_black_trees.adb:338:26: access discriminant in return aggregate would be a dangling reference
sal-gen_unbounded_definite_red_black_trees.adb:352:29: access discriminant in return aggregate would be a dangling reference
sal-gen_definite_doubly_linked_lists.adb:268:26: access discriminant in return aggregate would be a dangling reference
sal-gen_definite_doubly_linked_lists.adb:273:26: access discriminant in return aggregate would be a dangling reference
sal-gen_definite_doubly_linked_lists.adb:280:26: access discriminant in return aggregate would be a dangling reference
sal-gen_definite_doubly_linked_lists.adb:285:26: access discriminant in return aggregate would be a dangling reference
clang-10: warning: argument unused during compilation: '-specs=/tmp/GNAT-TEMP-000014.TMP' [-Wunused-command-line-argument]
clang-10: warning: argument unused during compilation: '-specs=/tmp/GNAT-TEMP-000014.TMP' [-Wunused-command-line-argument]


   compilation of wisitoken.adb failed
   compilation of wisi.adb failed

bug#43742: Unable to compile ada-mode

[Stephen Leake]

Colton Lewis <colton.w.lewis@protonmail.com> writes:

> On Sunday, October 4, 2020 6:01:10 PM CDT Stephen Leake wrote:
>> 
>> Colton Lewis <colton.w.lewis@protonmail.com> writes:
>> 
>> >
>> > emacs-27.1
>> > ada-mode-7.1.4
>> > gnat-10.2.1
>> 
>> What is "gnat-10.2.1"? where did you get it?
>
> GCC version 10.2.1 from the default Fedora 32 repositories. 

Ok. Apparently Debian testing has gnat-10.2.0. I could test with the latest
Debian gnat release.

> On a tangent, the online Emacs manual 

Where?

> says ada-mode should be included in the standard distribution, but it
> wasn't. 

ada-mode used to be in Emacs core, but I moved it to ELPA. Apparently
that's a more complex process than I realized.

> Should it be there?

There is not yet a mechanism to bundle ELPA packages in the emacs
distribution. I don't see the point of doing that; people should be used
to installing Emacs packages, just like they install Debian (or Fedora
or ...) packages.

>    [Ada]          wisi-ada.adb
>    [Ada]          wisitoken.adb
> sal-gen_unbounded_definite_red_black_trees.adb:308:26: access
> discriminant in return aggregate would be a dangling reference

That's a new instance of a known bug; see the WORKAROUND note at line
321 in that file; delete the '.all' and it magically works.

> clang-10: warning: argument unused during compilation:
> '-specs=/tmp/GNAT-TEMP-000014.TMP' [-Wunused-command-line-argument]

This I don't understand

-- 
-- Stephe

bug#43742: Unable to compile ada-mode

[Colton Lewis via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On Thursday, October 8, 2020 10:43:07 AM CDT Stephen Leake wrote:
> 
> > On a tangent, the online Emacs manual
> 
> Where?

First result on google for the string "emacs ada-mode".
First sentence under Installation section.

https://www.gnu.org/software/emacs/manual/html_mono/ada-mode.html#Installation

> >    [Ada]          wisi-ada.adb
> >    [Ada]          wisitoken.adb
> > sal-gen_unbounded_definite_red_black_trees.adb:308:26: access
> > discriminant in return aggregate would be a dangling reference
> 
> That's a new instance of a known bug; see the WORKAROUND note at line
> 321 in that file; delete the '.all' and it magically works.
Deleted ".all" everywhere the compiler complained. More errors.

wisitoken.ads:80:04: instantiation error at sal-gen_definite_doubly_linked_lists.adb:268
wisitoken.ads:80:04: instantiation error at sal-gen_unbounded_definite_queues.ads:88
wisitoken.ads:80:04: access discriminant in return aggregate would be a dangling reference
wisi.ads:497:04: instantiation error at sal-gen_unbounded_definite_red_black_trees.adb:308
wisi.ads:497:04: access discriminant in return aggregate would be a dangling reference

> 
> > clang-10: warning: argument unused during compilation:
> > '-specs=/tmp/GNAT-TEMP-000014.TMP' [-Wunused-command-line-argument]
> 
> This I don't understand

gprbuild grabs the first C compiler it can find on the system. I have
clang installed, so it uses that as the C compiler. Clang doesn't support
a "-spec" argument. 

https://docs.adacore.com/gprbuild-docs/html/gprbuild_ug/companion_tools.html

Might want to add
for Driver ("C") use "gcc";
somewhere.

bug#43742: Unable to compile ada-mode

[Simon Wright via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

I see. I always have GNAT first on my PATH, but of course on macOS GNAT isn't in the standard PATH so I have to.

I would have had similar problems, but it seems I used GCC 9.

> On 10 Oct 2020, at 00:04, Colton Lewis <colton.w.lewis@protonmail.com> wrote:
> 
> Might want to add
> for Driver ("C") use "gcc";
> somewhere.


[-- Attachment #2: Type: text/html, Size: 2628 bytes --]

bug#43742: Unable to compile ada-mode

[Stephen Leake]

I believe this should be fixed by ada-mode 7.1.8 with wisi 3.1.5; please
confirm.


-- 
-- Stephe

bug#43742: Unable to compile ada-mode

[Lars Ingebrigtsen]

Stephen Leake <stephen_leake@stephe-leake.org> writes:

> I believe this should be fixed by ada-mode 7.1.8 with wisi 3.1.5; please
> confirm.

More information was requested, but no response was given within a few
months, so I'm closing this bug report.  If the problem still exists,
please respond to this email and we'll reopen the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no