From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.devel Subject: Re: Adding transient to Emacs core Date: Tue, 20 Apr 2021 18:53:51 +0200 Message-ID: <87wnswgan4.fsf@bernoul.li> References: <87czuqi86o.fsf@bernoul.li> <83blaas1es.fsf@gnu.org> <87czupm8p9.fsf@bernoul.li> <83sg3lqfe1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19131"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 20 18:58:18 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lYtha-0004nf-DR for ged-emacs-devel@m.gmane-mx.org; Tue, 20 Apr 2021 18:58:18 +0200 Original-Received: from localhost ([::1]:45070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYthZ-0001Yz-BC for ged-emacs-devel@m.gmane-mx.org; Tue, 20 Apr 2021 12:58:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYtdQ-0007LK-8f for emacs-devel@gnu.org; Tue, 20 Apr 2021 12:54:00 -0400 Original-Received: from mail.hostpark.net ([212.243.197.30]:47992) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYtdO-0002bO-2G; Tue, 20 Apr 2021 12:54:00 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id A1E31160E8; Tue, 20 Apr 2021 18:53:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1618937631; bh=gJOwW+D47KQirYvW0OUInNal kIrbH4BSgNjwicl/WZg=; b=I9/87liICmiiRYFZ83JRoMKI0ZnPFWfFIXI0bDc3 PBbpsERbOu5aTjWup2sIRrrwOaagqxYRw8mw88XQrBp2H5ArcQEDF2Gz2RKKlK1U tS+sWSgWY8cGE5S5onUZSD/Ot7moUqvQTAEeYRIvYMZc/p7q2mRYQhAt1HWJbFoJ cOk= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id V4i_murfJFJR; Tue, 20 Apr 2021 18:53:51 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 756D9160AE; Tue, 20 Apr 2021 18:53:51 +0200 (CEST) In-Reply-To: <83sg3lqfe1.fsf@gnu.org> Received-SPF: none client-ip=212.243.197.30; envelope-from=jonas@bernoul.li; helo=mail.hostpark.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268211 Archived-At: Eli Zaretskii writes: >> Should I just push this to master myself or open a ticket in debbugs? > > Depends on how you feel about its current form. If you want some kind > of review and comments before pushing, debbugs is better. But if you > are certain the code is in good shape and any comments are bound to be > minor, please go ahead and push. I've pushed. Stefan Monnier already reviewed it last year and I've addressed his feedback. >> > ** transient.el >> > >> > This library implements support for powerful keyboard-driven menus. >> > Such menus can be used as simple visual command dispatchers. More >> > complex menus take advantage of infix arguments, which are somewhat >> > similar to prefix arguments, but are more flexible and discoverable. > > It's a start, thanks. Yeah... ;) I believe I mentioned that documentation still has to be improved. Sadly that begins with the most basic package description.