From: Thierry Volpiatto <thievol@posteo.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: `selected-frame` behavior have changed in emacs-28
Date: Sun, 25 Apr 2021 18:28:43 +0000 [thread overview]
Message-ID: <87wnsqz025.fsf@posteo.net> (raw)
In-Reply-To: <jwvr1iyuzyy.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1564 bytes --]
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Hi Thierry,
>
> Thierry Volpiatto [2021-04-25 12:33:48] wrote:
>> Up to emacs-27.2 I was using this code:
>>
>> (with-current-buffer helm-buffer
>> (let ((frame (selected-frame)))
>> [...]))
>>
>> selected-frame was returning the frame where helm-buffer was displayed.
>
> Note that `with-current-buffer` never affects the selected frame (nor
> the selected window), so the fact that `selected-frame` returned the
> one that displayed `helm-buffer` had nothing to do with your
> "(with-current-buffer helm-buffer".
Thanks it is what i understood but I was unsure.
>> In emacs-28, it have the same behavior when helm starts from a normal
>> buffer, but if I call helm from a minibuffer e.g. from M-:
>> selected-frame is returning the wrong frame whereas in emacs-27, the
>> frame handling helm-buffer is returned.
>> I expect here having the same behavior in emacs-27 and emacs-28.
>> Does something have changed in selected-frame?
>
> My crystal ball tells me this change is linked to Alan's changes to the
> handling of minibuffers.
I had the same idea, but I have the impression that the changes to
exit-minibuffer try to fix this behavior change, if it is the case
perhaps it would be better to fix this at root?
> I suggest you `M-x report-emacs-bug` about it
Ok will do.
> (and skip the "(with-current-buffer helm-buffer" part which just
> muddies the water).
Yes I am trying to find a suitable fix actually.
Thanks.
--
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 686 bytes --]
prev parent reply other threads:[~2021-04-25 18:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 12:33 `selected-frame` behavior have changed in emacs-28 Thierry Volpiatto
2021-04-25 15:54 ` Stefan Monnier
2021-04-25 18:28 ` Thierry Volpiatto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnsqz025.fsf@posteo.net \
--to=thievol@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.