From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg via Users list for the GNU Emacs text editor Newsgroups: gmane.emacs.help Subject: Re: Passing a list to a function Date: Mon, 12 Jul 2021 15:52:52 +0200 Message-ID: <87wnpvk5aj.fsf@zoho.eu> References: <87a6mrlp0q.fsf@zoho.eu> Reply-To: Emanuel Berg Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27222"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:KgMF/+NrA8KVP+Ha21PjsJwexbs= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 12 15:57:47 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m2wRP-0006r9-Eh for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 12 Jul 2021 15:57:47 +0200 Original-Received: from localhost ([::1]:41952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2wRO-0000Fr-9w for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 12 Jul 2021 09:57:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2wN0-0004jo-Lh for help-gnu-emacs@gnu.org; Mon, 12 Jul 2021 09:53:14 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:53402) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2wMw-0000Oz-V0 for help-gnu-emacs@gnu.org; Mon, 12 Jul 2021 09:53:14 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1m2wMt-0000Rg-Nw for help-gnu-emacs@gnu.org; Mon, 12 Jul 2021 15:53:07 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: help-gnu-emacs@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:131667 Archived-At: lisa-asket wrote: > Is it valid? Run this... (require 'checkdoc) (defun check-package-style () (interactive) (let ((msg "Style check...")) (message msg) (checkdoc-current-buffer t) ; TAKE-NOTES (message "%sdone" msg) )) (defalias 'check-style #'check-package-style) It says it is valid but Argument ‘hdlevels’ should appear (as HDLEVELS) in the doc string Probably "Sets" should be imperative "Set" Also try to byte-compile it, the byte-compiler then says it is valid but Warning: assignment to free variable ‘outline-heading-alist’ You can add (defvar outline-heading-alist) to make it quiet. > What do you think of this code? I would avoid using `setq' in defuns, especially in cases like yours, but it isn't wrong to do so. Also I think some of the data either appear several times or is a function of some other data (or both), so a lot can be pruned, for example the way you set "hstyle-hdl" ... > (defvar hstyle-hdl >    '( ("@c h1" . 1) ("@c h2" . 2) ("@c h3" . 3) ("@c h4" . 4) >       ("@c h5" . 5) ("@c h6" . 6) ("@c h7" . 7) ("@c h8" . 8) ) >    "Define names and levels for texinfo outline headings." ) ... you see how the elements seem to be ("@c hx" . x) where x is the position in the list (starting from 1) - yet you have the same data (x) hard-coded twice everywhere - that doesn't look good. -- underground experts united https://dataswamp.org/~incal