From: Emanuel Berg via Users list for the GNU Emacs text editor <help-gnu-emacs@gnu.org>
To: help-gnu-emacs@gnu.org
Subject: Re: Passing a list to a function
Date: Mon, 12 Jul 2021 15:52:52 +0200 [thread overview]
Message-ID: <87wnpvk5aj.fsf@zoho.eu> (raw)
In-Reply-To: ea-mime-60ec3758-3525-7d9be724@www-7.mailo.com
lisa-asket wrote:
> Is it valid?
Run this...
(require 'checkdoc)
(defun check-package-style ()
(interactive)
(let ((msg "Style check..."))
(message msg)
(checkdoc-current-buffer t) ; TAKE-NOTES
(message "%sdone" msg) ))
(defalias 'check-style #'check-package-style)
It says it is valid but
Argument ‘hdlevels’ should appear (as HDLEVELS) in the doc
string
Probably "Sets" should be imperative "Set"
Also try to byte-compile it, the byte-compiler then says it is
valid but
Warning: assignment to free variable ‘outline-heading-alist’
You can add
(defvar outline-heading-alist)
to make it quiet.
> What do you think of this code?
I would avoid using `setq' in defuns, especially in cases like
yours, but it isn't wrong to do so.
Also I think some of the data either appear several times or
is a function of some other data (or both), so a lot can be
pruned, for example the way you set "hstyle-hdl" ...
> (defvar hstyle-hdl
> '( ("@c h1" . 1) ("@c h2" . 2) ("@c h3" . 3) ("@c h4" . 4)
> ("@c h5" . 5) ("@c h6" . 6) ("@c h7" . 7) ("@c h8" . 8) )
> "Define names and levels for texinfo outline headings." )
... you see how the elements seem to be ("@c hx" . x) where
x is the position in the list (starting from 1) - yet you have
the same data (x) hard-coded twice everywhere - that doesn't
look good.
--
underground experts united
https://dataswamp.org/~incal
prev parent reply other threads:[~2021-07-12 13:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 5:32 Passing a list to a function lisa-asket
2021-07-12 12:01 ` Emanuel Berg via Users list for the GNU Emacs text editor
2021-07-12 12:36 ` lisa-asket
2021-07-12 13:52 ` Emanuel Berg via Users list for the GNU Emacs text editor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnpvk5aj.fsf@zoho.eu \
--to=help-gnu-emacs@gnu.org \
--cc=moasenwood@zoho.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.