From: Lars Ingebrigtsen <larsi@gnus.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: "João Távora" <joaotavora@gmail.com>, emacs-devel@gnu.org
Subject: Re: master b811ad1: Improve behavior of 'electric-pair-mode' in 'cc-mode'
Date: Sat, 06 Nov 2021 18:39:31 +0100 [thread overview]
Message-ID: <87wnllchf0.fsf@gnus.org> (raw)
In-Reply-To: <cf16a2e7-69f4-8577-968f-07b152a1576a@gmail.com> (Jim Porter's message of "Fri, 5 Nov 2021 22:29:34 -0700")
Jim Porter <jporterbugs@gmail.com> writes:
> I see this too, but as you say, it only happens with "make
> check-maybe" (or when running electric-tests.el manually *after* "make
> check-maybe"). I can't reproduce it otherwise. If I check out the
> commit before this patch, the issue goes away though.
I see it if some parts of the Emacs source changes -- then check-maybe
reports a failure. But it goes away after a full check. But doesn't
come back if I say check-maybe and electric-tests. :-/
> I'm not totally clear on what check-maybe does, but it seems to create
> some persistent state that causes the electric-tests to fail.
Yes, it must be doing that, but I'm also vague on what it actually does.
Is there anybody with any insights here?
> The failure I see is in `whitespace-chomping-dont-cross-comments' for
> `c-mode', which would seem to point to my patch being the culprit, but
> if I'm understanding what that function is testing, everything works
> as it should when I try it out interactively.
Yes, I'm not seeing any issues either when testing interactively.
The electric tests are quite involved -- I've added João to the CCs.
Perhaps there's something extra that has to be done here for those.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2021-11-06 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211106002248.1025.75379@vcs0.savannah.gnu.org>
[not found] ` <20211106002249.E08DE20A22@vcs0.savannah.gnu.org>
2021-11-06 4:21 ` master b811ad1: Improve behavior of 'electric-pair-mode' in 'cc-mode' Lars Ingebrigtsen
2021-11-06 5:29 ` Jim Porter
2021-11-06 17:39 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnllchf0.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.