From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix placement of toggle and radio button in Lucid menu. Date: Fri, 25 Feb 2022 13:52:25 +0100 Message-ID: <87wnhj152u.fsf@elite.giraud> References: <87sfs87i5o.fsf@elite.giraud> <87pmnc7f5c.fsf@yahoo.com> <87k0dk7ejd.fsf@yahoo.com> <878rtzb3hr.fsf@elite.giraud> <83h78nqguu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14793"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) Cc: luangruo@yahoo.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 25 14:22:29 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNaYF-0003cl-Qg for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Feb 2022 14:22:27 +0100 Original-Received: from localhost ([::1]:50388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNaYE-00038M-KT for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Feb 2022 08:22:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNa5R-0000hp-43 for emacs-devel@gnu.org; Fri, 25 Feb 2022 07:52:46 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:24623) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNa5P-0000CQ-8T; Fri, 25 Feb 2022 07:52:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=CT4wNQrS2k3MmIXG 3vhE2g766Txhq4/98+o8FZruR08=; h=in-reply-to:date:references:subject: cc:to:from; d=ledu-giraud.fr; b=tLdWFaqduITvAaPRTQSNP/DKEERTU4wfnSZ46P oKIM+bucJDDHe2UjKx5J+GAkxuK/Dh1Di3MbjBMEqVIdYVKT3vm0Sh3kCdu8vH6LHdkD1o bd/ns8w7YQrYAGEcbRl7ACfGX/bCjUkyh+WtpWM3HZIX+f34MjBgKx9e229NZEaBbn0OGa BQIYMFSIRW8IzaKQT+OC4gWtZXWVK+azOwlKUfzSKotuZRHmWOoFU4/yMv+irYdZOQTqg/ 8GI/AP6kHvoH6/7Q3UdKOh0Zx4bg4x43HUShWLdNasySLNpYRNjxuGNSzIH3xK6NRWfp5L Rmai+RmfHnhxV9OmoTTSz1mw== Original-Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 49642055 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 25 Feb 2022 13:52:35 +0100 (CET) In-Reply-To: <83h78nqguu.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 25 Feb 2022 14:18:49 +0200") Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286680 Archived-At: Eli Zaretskii writes: > Can we please take a step back and try to understand the issue better? > I asked a question in this thread; can we have an answer to that > question? I can answer for font's height and ascent on an example but I don't know how to have the "actual metrics of the upper-case characters shown" > Basically, I don't understand why the original code doesn't appear to > do its job as intended. If you do understand, please post a detailed > explanation of the reason. Ok so I found the button to be a bit to high regarding to their labels. My second patch place the base of the button *on* the baseline (ie. a bit lower than the actual code) But, in the mean time (with help of Po Lu's last mail), I understood that the code is intended to have the button in the middle of the baseline and the top of the font (am I correct?). Still it seems a bit too high. As I suggested in another message, it might be the size of the button that is too big here. -- Manuel Giraud