From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#55205: 28.1.50; completion--replace illegally mutates completion candidates Date: Sun, 01 May 2022 13:53:59 +0200 Message-ID: <87wnf5mpt4.fsf@gnus.org> References: <4d1b8687-20f2-137a-2739-7bba28828991@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36974"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Stefan Monnier , 55205@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 01 13:55:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nl8AR-0009Oe-8g for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 May 2022 13:55:11 +0200 Original-Received: from localhost ([::1]:57580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nl8AP-0000BY-Qt for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 May 2022 07:55:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nl8AI-0000B9-Hj for bug-gnu-emacs@gnu.org; Sun, 01 May 2022 07:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37655) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nl8AI-0001FC-8v for bug-gnu-emacs@gnu.org; Sun, 01 May 2022 07:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nl8AI-0005qy-3x for bug-gnu-emacs@gnu.org; Sun, 01 May 2022 07:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 May 2022 11:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55205 X-GNU-PR-Package: emacs Original-Received: via spool by 55205-submit@debbugs.gnu.org id=B55205.165140605422442 (code B ref 55205); Sun, 01 May 2022 11:55:02 +0000 Original-Received: (at 55205) by debbugs.gnu.org; 1 May 2022 11:54:14 +0000 Original-Received: from localhost ([127.0.0.1]:59785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nl89W-0005pu-LN for submit@debbugs.gnu.org; Sun, 01 May 2022 07:54:14 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:58492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nl89V-0005pg-5Z for 55205@debbugs.gnu.org; Sun, 01 May 2022 07:54:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=E04wHvcGcAbIkiTi6WPlsVqRsUJt5zTjYXBFqVFmmuQ=; b=n3PBY8QpR0r7BRdh4VM27rW27q Pwrh32ul6YJjvDVYM1X0J/qgwFb4h/GWhS2OOKvxDfTkqy1PqBB6AAXne+ExM3cZmbcyQZEcAKxyR 2saWf8xd5e+/hydleD7qd8PbfqhBABFMlHGEuMok1HrzQWc5kvZhDrEmBmeuSyHSf9rA=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nl89K-0003vc-Q0; Sun, 01 May 2022 13:54:05 +0200 X-Now-Playing: Colleen's _A Flame My Love, A Frequency_: "Summer Night (Bat Song)" In-Reply-To: <4d1b8687-20f2-137a-2739-7bba28828991@daniel-mendler.de> (Daniel Mendler's message of "Sun, 1 May 2022 10:27:56 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231131 Archived-At: Daniel Mendler writes: > The function completion--replace mutates the replacement string, it > strips the text properties. I don't think that's, strictly speaking, illegal. :-) Anyway, I agree that it's unfortunate that completion destructively modifies the strings it's handed, and this has been discussed extensively over the years (and there's probably several bug reports open about that, although I can't find them now). I don't remember why we're doing that, but I seem to vaguely recall that there's a reason... Anybody? We should (at least) document this in all the relevant functions. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no