From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#33007: 27.0.50; Proposal for function to edit and return string Date: Mon, 09 May 2022 11:49:57 +0200 Message-ID: <87wnevavcq.fsf@gnus.org> References: <86pnwh4je8.fsf@protected.rcdrun.com> <83bm81xl84.fsf@gnu.org> <20181011063321.GD27672@protected.rcdrun.com> <87lg74zk2k.fsf@web.de> <87v8uybp1c.fsf@gnus.org> <871qxlj293.fsf@web.de> <875ymx7ga6.fsf@gnus.org> <86pml5gp6m.fsf@mail.linkov.net> <87a6c8jhjb.fsf@gnus.org> <86czh3vp4g.fsf@mail.linkov.net> <87sfpyd8wu.fsf@gnus.org> <86wnfascft.fsf@mail.linkov.net> <86r15hvelj.fsf@mail.linkov.net> <87fslxpl29.fsf@gnus.org> <86ee13j348.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40523"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Michael Heerdegen , 33007@debbugs.gnu.org, Jean Louis To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 09 11:51:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1no02q-000AKt-Uq for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 11:51:12 +0200 Original-Received: from localhost ([::1]:58954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1no02p-00070Z-I6 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 05:51:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no02g-0006yW-PY for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 05:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34019) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1no02g-0004rs-Gm for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 05:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1no02g-0005Hn-Fb for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 05:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 May 2022 09:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33007 X-GNU-PR-Package: emacs Original-Received: via spool by 33007-submit@debbugs.gnu.org id=B33007.165208981120251 (code B ref 33007); Mon, 09 May 2022 09:51:02 +0000 Original-Received: (at 33007) by debbugs.gnu.org; 9 May 2022 09:50:11 +0000 Original-Received: from localhost ([127.0.0.1]:56149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no01r-0005GZ-BY for submit@debbugs.gnu.org; Mon, 09 May 2022 05:50:11 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:39948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no01o-0005GH-MT for 33007@debbugs.gnu.org; Mon, 09 May 2022 05:50:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5d7duzgHGeuadVyI8Z+YX2B6n+01eZJHY4Q+9rTBZ/Q=; b=azuB4T7HAwxFVbEUwmyRRTCrKX ms4ckJSjk6MishqcSaGsW2stpwDR2Ojhrvi0NasfNePTQg4VbYiLVqFR/GUU/0YrhqwnBGPQL02Mm PuBpG3iaVy8n2bDH++/PIQFUUBwrq3iEALVYRufeyF8+Ck1ADtIn1hfYs00r3TSIkwJI=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1no01e-0004EK-HT; Mon, 09 May 2022 11:50:02 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEX9/f0hDA67wq9T qNr2723e3diWXk27olJdTkhSp7b///+JyUX3AAAAAWJLR0QKaND0VgAAAAd0SU1FB+YFCQkjMC6A 7ocAAAGVSURBVDjLtdG/T4NAFAfwy5Grrmdsy4inJR2bEBO7GYLWkTQe0c0QSxlNh9qx0BRulsX7 b70fTXtAm+jgGxj48H3v3gHAoS4sz/NAoIoa70FvD0sBiO6RaVgmCZujIwkBaQ2QmhHKVqvABGiC ORx2JXQuFdy3Ei8SnoKH1owjoE8V9QQ8Br4JtgQ616uboBak722wT4AeTssW6D12YJ6q8yuobd6F nneXMblIEJrQF4kMZ7jfAFAg8ooF2I1Was4BIocs4imcExK7cX6GRfUUDNcJWxPIooLlcY4k9NVx h9uU5QQWLkvLPEcMY7tU4G6ZTrC02OYI6k4CosQlcURcogpNRWJS3xwl8pHZYg9KqbFHlHyIJTFm 2JZfHMD9jAlZiU4423DOzcQMDDN5XLypxgagQYjKKw21hKpzBRWvmgDle3vMq3ED0Le4w4o34DkI fNG94k2QV8F1/St83fhkQK+92ybsLtwanQA4+ksCib9kOcBCoeOEFISIEt8PEllvwApbicmC6kQD Jhrqw8Ul6lYzgEY/cgiymJjq9IAAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDUtMDlUMDk6MzU6 NDgrMDA6MDCOxssmAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA1LTA5VDA5OjM1OjQ4KzAwOjAw /5tzmgAAAABJRU5ErkJggg== X-Now-Playing: Blaine L. Reininger's _Broken Fingers_: "Petit Piece Chinoise" In-Reply-To: <86ee13j348.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 08 May 2022 21:22:47 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231701 Archived-At: Juri Linkov writes: > - (pop-to-buffer-same-window (generate-new-buffer "*edit string*")) > + (pop-to-buffer (generate-new-buffer "*edit string*") > + '(display-buffer-below-selected > + (window-height . (lambda (window) > + (fit-window-to-buffer window nil 10))))) Shouldn't it wait to do the fitting until it's prepared the buffer? I.e., it should create the buffer first, insert all the stuff, and then pop to it? > - (kill-buffer (current-buffer)) > + (quit-window 'kill) I think we really want to kill the buffer? It'd be disturbing to leave thees buffers lying around from a function call like read-string-from-buffer. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no