From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Roland Winkler Newsgroups: gmane.emacs.devel Subject: Re: master 70341cab3e: string-equal-ignore-case: new function Date: Tue, 26 Jul 2022 14:00:53 -0500 Message-ID: <87wnbz1yxm.fsf@gnu.org> References: <165885780615.5477.9618918327695992186@vcs2.savannah.gnu.org> <20220726175007.02EE9C00095@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29654"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Sam Steingold To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 26 21:03:27 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGPq2-0007Wm-Gv for ged-emacs-devel@m.gmane-mx.org; Tue, 26 Jul 2022 21:03:26 +0200 Original-Received: from localhost ([::1]:45400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGPq0-0005HK-B2 for ged-emacs-devel@m.gmane-mx.org; Tue, 26 Jul 2022 15:03:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGPna-0003mk-Rg for emacs-devel@gnu.org; Tue, 26 Jul 2022 15:00:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44020) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGPna-0007xu-Hb; Tue, 26 Jul 2022 15:00:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=YY0GuUU9TPa0v2obP6E5eRwLsodEPYdWDFxBTQCv11U=; b=X9KO6303mNEmKTRHbf89 b+7clxflCOCfqLJ6ti3luDkcYRStT/ZpP5QFIQlRxZEEe0Z0H2YT/L6OCHdlcTZVwcoGWt7DVQ7vJ EwlN4XzoOHgyjnWr8Dm/Kvum5wR9db66aQPJbmwB3C+MF2dr+IdIwCIOYabYdDOCQ9XN+KDDwn6tX p1m2rJD9oDjRUHKsrgnLzzIMlwIoAinuX+wbm8K153068wimr/dXhmorG3bAoqW+1mtaWfzlP7iY0 fE4BKvVsptdbjXiXZvVVIMB8q6b6mm0ddzK9uzTGySK7G29jk861x9fgrDaoEWUjmJuIwLyuWR3zF lm8K2Tj76sPY+Q==; Original-Received: from [2600:1700:5650:f790::42] (port=59262 helo=regnitz) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGPna-0002eh-65; Tue, 26 Jul 2022 15:00:54 -0400 In-Reply-To: <20220726175007.02EE9C00095@vcs2.savannah.gnu.org> (Sam Steingold's message of "Tue, 26 Jul 2022 13:50:06 -0400 (EDT)") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292714 Archived-At: On Tue, Jul 26 2022, Sam Steingold wrote: > +(defun string-equal-ignore-case (string1 string2) > + "Like `string-equal', but case-insensitive. > +Upper-case and lower-case letters are treated as equal. > +Unibyte strings are converted to multibyte for comparison." > + (eq t (compare-strings string1 0 nil string2 0 nil t))) Isn't this a perfect candidate for an inline function, i.e., defsubst instead of defun?