From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries Date: Wed, 07 Sep 2022 18:27:18 +0000 Message-ID: <87wnaft4zd.fsf@posteo.net> References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <87fsh4e01q.fsf@posteo.net> <83wnafgvre.fsf@gnu.org> <87h71jnpty.fsf@posteo.net> <83mtbbgik1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13273"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 55039@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 07 20:28:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVzme-0003KG-Ug for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Sep 2022 20:28:21 +0200 Original-Received: from localhost ([::1]:51826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVzmd-0002cs-16 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Sep 2022 14:28:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVzmM-0002ce-3b for bug-gnu-emacs@gnu.org; Wed, 07 Sep 2022 14:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39251) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVzmL-0004O3-RY for bug-gnu-emacs@gnu.org; Wed, 07 Sep 2022 14:28:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVzmL-0007m8-Nh for bug-gnu-emacs@gnu.org; Wed, 07 Sep 2022 14:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Sep 2022 18:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55039 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 55039-submit@debbugs.gnu.org id=B55039.166257525629854 (code B ref 55039); Wed, 07 Sep 2022 18:28:01 +0000 Original-Received: (at 55039) by debbugs.gnu.org; 7 Sep 2022 18:27:36 +0000 Original-Received: from localhost ([127.0.0.1]:56183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVzlv-0007lS-OK for submit@debbugs.gnu.org; Wed, 07 Sep 2022 14:27:36 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:50037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVzlt-0007lF-Sy for 55039@debbugs.gnu.org; Wed, 07 Sep 2022 14:27:34 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id B19FA240027 for <55039@debbugs.gnu.org>; Wed, 7 Sep 2022 20:27:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662575247; bh=TQMlw0VJnV2jaLt8KXHTOKQsV6EbH0nJVvqAyzK5Cvw=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=h14k9n8hhEEqmdyLqnoVCeqhjgvm0ZVEzee+JuYqiy2m6nV3wyzuUbYjg22QrczL0 mRqMr5XwCNQXu3nE/fokvkVU71sJC72KdCo+knCvp/mR6ZHhnyLcVBUw3BPg20VLay K/BYSwGXtk+yoF8fm57zydpRFPpke3ZvPTfqWIcHmb8J2FQnn2edM/So7tnQuz4Mc2 ShEg1h7dHPINhodnGxcp/bKfcIUn+ylG/d1LGxfAL2tj3JgLVkEyCFVnGBP++W2LyR RFmMZykvHcv6F1o1eUDu2RF4t1NtLeWvjSx7I1fuzseraYtHGlL9BugURSV8WxEntz 4HjPAJG70wnmg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MN9ht58ckz6trP; Wed, 7 Sep 2022 20:27:25 +0200 (CEST) In-Reply-To: <83mtbbgik1.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 07 Sep 2022 21:12:30 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241798 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: larsi@gnus.org, 55039@debbugs.gnu.org >> Date: Wed, 07 Sep 2022 15:53:29 +0000 >> >> >> --- a/doc/emacs/maintaining.texi >> >> +++ b/doc/emacs/maintaining.texi >> >> @@ -694,7 +694,10 @@ Log Buffer >> >> (@code{log-edit-generate-changelog-from-diff}), to generate skeleton >> >> ChangeLog entries, listing all changed file and function names based >> >> on the diff of the VC fileset. Consecutive entries left empty will be >> >> -combined by @kbd{C-q} (@code{fill-paragraph}). >> >> +combined by @kbd{C-q} (@code{fill-paragraph}). By default the >> >> +inserted file names will just be the files without a path. If >> >> +@code{diff-add-log-relative-names} is non-nil, a partial path relative >> >> +to the VC root directory will be inserted instead. >> > >> > GNU Coding Standards frown on using "path" for anything but PATH-style >> > directory lists. Please use "leading directories" or somesuch here, >> > as that's what you mean. >> >> I've just remove the changes to the manual from my patch. > > Why? That was nowhere near what I intended to say with the above > comments, which were minor. It wasn't because of your comments, rather I just felt mentioning it was too clumsy, and a few others said they didn't feel it was necessary to mention the option in the manual. But if you think that it should be added, then I'll try it again and take your comments into account.