From: Visuwesh <visuweshm@gmail.com>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 58070@debbugs.gnu.org
Subject: bug#58070: [PATCH] Add tamil99 input method
Date: Tue, 27 Sep 2022 07:59:39 +0530 [thread overview]
Message-ID: <87wn9psg6k.fsf@gmail.com> (raw)
In-Reply-To: <87ill98u3m.fsf@gmail.com> (Visuwesh's message of "Tue, 27 Sep 2022 07:19:17 +0530")
[செவ்வாய் செப்டம்பர் 27, 2022] Visuwesh wrote:
>> I tried out your implementation, and am having difficulty getting it
>> working correctly. This is likely because I have an Ergodox keyboard
>> with a non-standard keyboard layout. I have told quail about this
>> keyboard layout by setting the quail-keyboard-layout variable. But, your
>> implementation assumes a qwerty layout. It should instead call
>> quail-keyboard-translate or quail-keyseq-translate to translate
>> keystrokes.
>
> Hmm, this is weird. I thought Quail did the translation job for me
> which is why I boldly assumed the qwerty layout and coded it that way.
> I will try to change Xorg's keyboard layout and test it. Thanks for
> testing!
[ Looks like Quail does not hold your hand in the
UPDATE-TRANSLATION-FUNCTION. Reading `quail-update-translation'
again, I see the block about keysequence translation now. ]
>> [...] merely instruct quail to do the necessary translation by
>> passing a non-nil kbd-translate argument to quail-define-package.
>
> Here, I'm confused. I pass a non-nil KBD-TRANSLATE argument as well...
Thanks for the hint on quail-keyseq-translate, I fixed it with the
following patch
diff --git a/tamil99.el b/tamil99.el
index 3461ccd..7262d30 100644
--- a/tamil99.el
+++ b/tamil99.el
@@ -105,7 +105,7 @@ consonant pair or hard-soft consonant pair was handled.")
;; pulli regardless of the character before point.
(cond
((eq flag t)
- (let ((key quail-current-key))
+ (let ((key (quail-keyseq-translate quail-current-key)))
(cond
((and (equal key "W")
(and (eq (char-before (point)) ?்)
next prev parent reply other threads:[~2022-09-27 2:29 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 10:00 bug#58070: [PATCH 0/1] Add tamil99 input method Arun Isaac
2022-09-25 10:02 ` bug#58070: [PATCH] " Arun Isaac
2022-09-25 11:38 ` Visuwesh
2022-09-25 13:59 ` Eli Zaretskii
2022-09-25 14:14 ` Visuwesh
2022-09-25 14:23 ` Eli Zaretskii
2022-09-25 14:38 ` Visuwesh
2022-09-25 15:55 ` Eli Zaretskii
2022-09-26 20:59 ` Arun Isaac
2022-09-27 6:25 ` Eli Zaretskii
2022-09-27 20:34 ` Arun Isaac
2022-09-26 20:55 ` Arun Isaac
2022-09-27 1:49 ` Visuwesh
2022-09-27 2:29 ` Visuwesh [this message]
2022-09-27 6:37 ` Eli Zaretskii
2022-09-27 7:34 ` Visuwesh
2022-09-27 7:53 ` Eli Zaretskii
2022-09-27 9:24 ` Robert Pluim
2022-09-27 9:40 ` Eli Zaretskii
2022-09-27 10:11 ` Visuwesh
2022-09-27 20:32 ` Arun Isaac
2022-09-27 6:23 ` Eli Zaretskii
2022-09-27 7:52 ` Visuwesh
2022-09-27 8:03 ` Eli Zaretskii
2022-09-27 10:15 ` Visuwesh
2022-10-12 8:40 ` Arun Isaac
2022-10-12 14:00 ` Eli Zaretskii
2022-10-15 8:23 ` Arun Isaac
2022-09-27 20:19 ` Arun Isaac
2022-09-27 20:26 ` Arun Isaac
2022-09-28 2:30 ` Eli Zaretskii
2022-09-25 10:13 ` bug#58070: [PATCH 0/1] " Eli Zaretskii
2022-09-25 11:16 ` Arun Isaac
2022-10-12 8:41 ` Arun Isaac
2022-10-12 13:55 ` Eli Zaretskii
2022-10-15 8:34 ` Arun Isaac
2022-10-15 9:16 ` bug#58070: [PATCH v2] " Arun Isaac
2022-10-15 14:42 ` bug#58070: [PATCH 0/1] " Visuwesh
2022-10-18 7:11 ` Arun Isaac
2022-10-18 18:00 ` bug#58070: [PATCH v3] " Arun Isaac
2022-10-19 11:41 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn9psg6k.fsf@gmail.com \
--to=visuweshm@gmail.com \
--cc=58070@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.