From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Mon, 10 Oct 2022 10:14:41 +0200 Message-ID: <87wn98nlhq.fsf@gnus.org> References: <875yhzmz25.fsf@posteo.net> <83h715yxz2.fsf@gnu.org> <87h715dnut.fsf@posteo.net> <87edw955ls.fsf@gnus.org> <8735coewsk.fsf@posteo.net> <871qs7ztgq.fsf@gnus.org> <87o7vbg56k.fsf@posteo.net> <874jx3ye41.fsf@gnus.org> <87bkrbfz8l.fsf@posteo.net> <871qs5lpo2.fsf@posteo.net> <87mtatagzv.fsf@gnus.org> <87edw5n2zm.fsf@posteo.net> <87o7v97zy2.fsf@gnus.org> <87bkr9newj.fsf@posteo.net> <871qs57yai.fsf@gnus.org> <87y1udlzlt.fsf@posteo.net> <87o7v953uf.fsf@gnus.org> <87tu50nca7.fsf@posteo.net> <87a6652lyb.fsf@posteo.net> <875ygtqdho.fsf@gnus.org> <87wn99114w.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16093"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 57639@debbugs.gnu.org, Protesilaos Stavrou To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 10 10:15:55 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohnx5-0003w0-8K for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Oct 2022 10:15:55 +0200 Original-Received: from localhost ([::1]:53172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohnx4-0001ys-3c for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Oct 2022 04:15:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohnwE-0001vs-RN for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 04:15:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46776) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohnwE-0008CH-E9 for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 04:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohnwE-0006Om-A6 for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 04:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Oct 2022 08:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.166538969224565 (code B ref 57639); Mon, 10 Oct 2022 08:15:02 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 10 Oct 2022 08:14:52 +0000 Original-Received: from localhost ([127.0.0.1]:45854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohnw4-0006O9-K6 for submit@debbugs.gnu.org; Mon, 10 Oct 2022 04:14:52 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:52708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohnw3-0006Nw-Mr for 57639@debbugs.gnu.org; Mon, 10 Oct 2022 04:14:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fbQcYHGCptEbP/OFW6YkcwWFKyeDMfzGVPqFE3kR1x0=; b=tXyFS7rcMN/j5sE0Wo0WvGd5rx KsYvNvNhXNPLrdHrkSPw4962SICh8f32x1KsSTfNjxTaHy3J5Qhc5Np7XKLdEg/VZdIHqQ1CwcVWS 4UbKwvj+JgWnGc4Rxrl86Ad+R7euR1CPtLDltVPzc8UeJIzeg9N4BDPsTY9KIFzLPQGA=; Original-Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohnvu-0006YR-FK; Mon, 10 Oct 2022 10:14:44 +0200 In-Reply-To: <87wn99114w.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 09 Oct 2022 15:13:03 +0000") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEUWBQxTFC7IqqD/ //8b8hccAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YKCgc6HWokDt8AAAGQSURBVCjPNVI7bh0xDBwa 1CtSUQb3AUlvIMegADlAOq4h3cCNc4rkBnbxUqdIAr89pUcGvAuswBU5mo8AGY6PR/YSAOvgWxwR WRDFAprZob1qGKCS6zPCqq029sidaUlkRlroy1NEIOelPeM2noiDKuUUuImrEK3J3fcIef6LBT1z CvDjn9aAn+Uiii/HT0vU7VvGsE////QF/Zmn2unySAZZXjopnF6/kq94UxPcvD6SuW1DzfFw/UUJ tjs5ysO1kPGONG04HU2prI4iIsdxhVJXCeHGcYRTKYFxZjGpOHmYxfn3ZbWN8Ibo0bBB7lv0IkVL qQS2ieWDRkWrxBdR0caVPjULcrp3OD3sajVtANsY3DQzoYTUnG7mKbRqFEMfy20zjN01BvMIOh9b yWiNxGmISiQpzL05ffOoKnS5c5gR6mo2EgEHkuGZ6ZgA87Um00pnsQnmFHeewGugMHDAtnURmF5Z VyB2aoVNRryFCLzN1pWjRGFrSPqW77+UHjp1DV30acXKRVYRlcQyZlL7G1c+VmbbgwPeAAAAJXRF WHRkYXRlOmNyZWF0ZQAyMDIyLTEwLTEwVDA3OjU4OjI5KzAwOjAwCEP3NwAAACV0RVh0ZGF0ZTpt b2RpZnkAMjAyMi0xMC0xMFQwNzo1ODoyOSswMDowMHkeT4sAAAAASUVORK5CYII= X-Now-Playing: Sheila Chandra's _Nada Brahma_: "Question the Answer" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244986 Archived-At: Philip Kaludercic writes: > The last issue preventing this patch from being merged is that > expressions marked for auto-loading are not gathered. I believe one > option was adding etc/themes to the list of scraped directories, but > that would require comments like > > ;;;###autoload > (when (and (boundp 'custom-theme-load-path) > load-file-name) > ;; Add theme folder to `custom-theme-load-path' when installing over MELPA. > (add-to-list 'custom-theme-load-path > (file-name-as-directory (file-name-directory load-file-name)))) > > from leuven-theme.el to be removed. Ah, right. Well, we could come up with a special rule for etc/themes. For instance, we could use ;;;###theme-autoload (put ...) for these things, and add a function to loaddefs-gen that only fetched those for the Emacs build (it'd almost be trivial -- we just bind lisp-mode-autoload-regexp to ";;;###theme-autoload" and then point the scraping function at etc/themes).