From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: Stylistic changes to tree-sitter code Date: Sat, 29 Oct 2022 13:44:55 +0800 Message-ID: <87wn8j2nfs.fsf@yahoo.com> References: <87h6zp75nt.fsf.ref@yahoo.com> <87h6zp75nt.fsf@yahoo.com> <87h6zptloj.fsf@gmail.com> <87y1t06apv.fsf@yahoo.com> <87k04ksa4f.fsf@gmail.com> <87k04k5stm.fsf@yahoo.com> <875yg34aas.fsf@yahoo.com> <0E4C5439-B28D-420A-9E4A-BA059269AD57@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20426"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Robert Pluim , emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 29 07:55:15 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooeoN-0005DD-4Y for ged-emacs-devel@m.gmane-mx.org; Sat, 29 Oct 2022 07:55:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooemr-0004X4-6U; Sat, 29 Oct 2022 01:53:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooeed-0000mJ-6W for emacs-devel@gnu.org; Sat, 29 Oct 2022 01:45:16 -0400 Original-Received: from sonic301-30.consmr.mail.ne1.yahoo.com ([66.163.184.199]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ooeeb-00023X-38 for emacs-devel@gnu.org; Sat, 29 Oct 2022 01:45:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667022307; bh=EcUqw23sSVBj8FnOR4XH0msbl0u+m41pC3Vs5wxA504=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=OzFb2drfU6hZMPX6OTW9rT9acnMmkd0JPeoryqpIgbH/qu2zR3zUBrJhei+jrFyfklPnk35iniwxJBAR72DWdGx295n5vgUVn1kfZkgyzJ3qlwxfKLljkFsbA7UmwKI/dhVR9WycjqBM4sQVgkX8A8Pdnacaf5jvEI3MJi88OWKczYF2zPhtytTwc5AKyXS3r4qNkI6POM7blvJG2MzEoPGq+hSemPuO+XdMMzA6ATbhz1C2c0BBRRhpYPZoISCkN08jyyqUr722Yv0mf6tMwhuEgFWQ02Ye+kNiLxKE6XFAiUrA0ZAyeAgBAZojYebdWMCtdQ9wz4G5JiEyDGPlVA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667022307; bh=kVKF9x21rro2C52SA5fBM9oxKvEPmweQ93+1WWr6FDD=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=uanUJ1rRo1w2OY/HQcoDY3qC1caARerprE5YJlu6lvOMYsVoQsLt6pTcEtdy3JJlC70b/G2+Gg03X5O9hmcJMnybc+mJe1qoQwH0OexweFoLxsGgFJBag16f8X1D5jfX3jcmHxe5C0Bj05PcD0K6DW/G2SAsRuK8xn5IGgTr3D8IjdE/eUpnO70cYCJelDuaesCKeAOFDZH9st0SoritLi3T8v7Hz6i5m5WS7ZHVOVhcXU64Ds98xGfM5cYdOpwaIxthYnVe/MVQJ078C68MmwxBGAVrMt2QNbDyoTh6iOk0xmVIatfnKL/T5HEvtmZAO3ps91BxlZOFzMLcwvdrDg== X-YMail-OSG: GxnzblwVM1m4eJidk3YGClftuZZOH52kvU_VPL23pkIhb_vnKstJA1p0BPhuUpK Au_9e7m810x6ghjEMpcu12jthtM6bb1KXIC2dQt2TRl1BthBLLQ4aQ0TlnmR9HeyQyblqD7qO4xT OKzkpADsnmNquhGkeVX7StJS4wTtTMVeJd0LY9H3gs9mks4eEFO2IWduWvXL12nb5wHxm5U7d_th eLWmY6oCfH6OX6GKjUrZ4SO86.vucMh_f47P9VS9Hb.rkVn0yoZNDnxYF3tUoAOwid68TN0Trdex AvcA5JjWMsN9w9wchFYtpUMTcpBVoR9k78RbJPX2Ms6NZ2USZ8TVweLeyxyjJR0YafRC..hcaLJj l3u78HlETAdM.XfJf_uZaANWByOQRpFnXYNzILpNoSf7xM4N3pnqg6gAb70Lno5PHUOSJv19Yaxt YJ8mmbM10O8BrsD09kaL0CLAe0mDMww8L2G4DRAMeCeyT_reYKTINzqxV_jq8t.74LvZEHCpeJSX DIStMo7ifHmtEwej7Q4lQgQlwqRNVrsbGii4YC6UhtLu.rnWLbUSBWA.eUeuBH7pfaIr3u_W6Ty7 0Rs9drRtlw8flczv7I7cQAEC3yfasGK_xIXIc8wBCmqaU41d..4CKoqVD8e.aNEaUnoCTtsKrTYW 2XZYsnXub_YE7YxeI8Q8CZllDBYQBMVRhzSa_n9krSgNw8yi02pJoD0gayXmKqgFezWJ1f6xgBsC Qwz2VNXdlGqlQdIbq0h_5077JerPOLN49AfMdX5o6O_sAqzRyHwkJa_mzMRP4duIui6Rtnpw_yc6 q07OfixMhl5xbzpE3AtfQuS4v_e6hYmddZEc60Oeu0 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Sat, 29 Oct 2022 05:45:07 +0000 Original-Received: by hermes--production-sg3-74fb94585-65f2n (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID ed314a0efc276f66ef41f8152e90f7da; Sat, 29 Oct 2022 05:45:01 +0000 (UTC) In-Reply-To: <0E4C5439-B28D-420A-9E4A-BA059269AD57@gmail.com> (Yuan Fu's message of "Fri, 28 Oct 2022 21:19:19 -0700") X-Mailer: WebService/1.1.20783 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.184.199; envelope-from=luangruo@yahoo.com; helo=sonic301-30.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298719 Archived-At: Yuan Fu writes: > Ah, yes, the patch compiles fine, though there is a segfault: I > believe you forgot to initialized the tem variable. > > @@ -449,21 +453,28 @@ treesit_symbol_to_c_name (char *symbol_name) > treesit_find_override_name (Lisp_Object language_symbol, Lisp_Object *na= me, > Lisp_Object *c_symbol) > { > + Lisp_Object tem; > + > CHECK_LIST (Vtreesit_load_name_override_list); > - for (Lisp_Object list =3D Vtreesit_load_name_override_list; > - !NILP (list); list =3D XCDR (list)) > + > + FOR_EACH_TAIL (tem) > { > - Lisp_Object lang =3D XCAR (XCAR (list)); > + Lisp_Object lang =3D XCAR (XCAR (tem)); > CHECK_SYMBOL (lang); > + > if (EQ (lang, language_symbol)) > { > - *name =3D Fnth (make_fixnum (1), XCAR (list)); > + *name =3D Fnth (make_fixnum (1), XCAR (tem)); > CHECK_STRING (*name); > - *c_symbol =3D Fnth (make_fixnum (2), XCAR (list)); > + *c_symbol =3D Fnth (make_fixnum (2), XCAR (tem)); > CHECK_STRING (*c_symbol); > + > return true; > } > } > + > + CHECK_LIST_END (tem, Vtreesit_load_name_override_list); > + > return false; > } Right, so if you add "tem =3D Vtreesit_load_name_override_list" above "FOR_EACH_TAIL (tem)", does it work? > Also, out of curiosity, I thought active voice is good and passive > voice is bad? Though the subject here doesn=E2=80=99t add any useful > information, I recon. But not in comments and documentation. IME, a very important point in writing documentation and comments is to avoid the use of pronouns unless absolutely necessary: "I", "you", "we", et cetera. Especially "we", which is also so hard to avoid even I make the mistake of using it occasionally. Thanks.