all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Danny Freeman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: arash@gnu.org, arstoffel@gmail.com, 59338@debbugs.gnu.org
Subject: bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows
Date: Fri, 18 Nov 2022 08:39:13 -0500	[thread overview]
Message-ID: <87wn7swf4e.fsf@dfreeman.email> (raw)
In-Reply-To: <83cz9kd99x.fsf@gnu.org>


Eli Zaretskii <eliz@gnu.org> writes:

>
> Not sure I understand why this matters in the context of this
> discussion.  We need to make eglot--path-to-uri produce valid file://
> URL on MS-Windows and on Posix systems, right?  Then why does it
> matter how URI schema are defined?  What am I missing?

The current eglot--path-to-uri implementation should produce a valid
file:// url unless what it receives is already a URL.

So it could receive something like:

/home/user/project/whatever.c
d:/what/home/is/on/windows/whatever.c

Both of which should be transformed into file:// URLs
OR what it receives may already be a URL like

zipfile:home/user/project.zip::/path/in/zip.c

If it receives a URL, we want to pass it along, and not transform it
into a file:// URL.

If it is a full windows path, we DO want to turn that into a file url.

So how do we detect that is is a windows path, and not a URL already?
That's what I was trying to get at in the other message you replied to.
Just checking the user's current OS is not enough, because this function
could also receive a URL on Windows.

-- 
Danny Freeman





  reply	other threads:[~2022-11-18 13:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 16:51 bug#59338: 29.0.50; Commit 1a2d603bb3 breaks Eglot on Windows Arash Esbati
2022-11-17 17:06 ` Eli Zaretskii
2022-11-17 17:18   ` Augusto Stoffel
2022-11-17 22:27     ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-17 23:12       ` Augusto Stoffel
2022-11-18  7:14         ` Eli Zaretskii
2022-11-18 13:39           ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-11-18 14:35             ` Eli Zaretskii
2022-11-18 14:55               ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-18 20:01                 ` Arash Esbati
2022-11-18  7:12       ` Eli Zaretskii
2022-11-23 12:51         ` João Távora
2022-11-24 13:42           ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-24 15:27             ` João Távora
2022-11-17 22:33   ` Arash Esbati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn7swf4e.fsf@dfreeman.email \
    --to=bug-gnu-emacs@gnu.org \
    --cc=59338@debbugs.gnu.org \
    --cc=arash@gnu.org \
    --cc=arstoffel@gmail.com \
    --cc=danny@dfreeman.email \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.