From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] 11 new packages! Date: Sat, 26 Nov 2022 20:07:39 +0000 Message-ID: <87wn7hh438.fsf@posteo.net> References: <87r0y6ug9z.fsf@disroot.org> <87y1sct2hp.fsf@posteo.net> <87k03vf5m8.fsf@disroot.org> <87edu2narn.fsf@posteo.net> <8735aieqtr.fsf@disroot.org> <87cz9mlq3o.fsf@posteo.net> <875yfdd5ad.fsf@disroot.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6013"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Developer List To: Akib Azmain Turja Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 26 21:08:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oz1Th-0001Mg-Us for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Nov 2022 21:08:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oz1So-0003Pn-Na; Sat, 26 Nov 2022 15:07:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz1Sm-0003PZ-Q8 for emacs-devel@gnu.org; Sat, 26 Nov 2022 15:07:48 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz1Sk-0002hv-Ad for emacs-devel@gnu.org; Sat, 26 Nov 2022 15:07:48 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id E273D240027 for ; Sat, 26 Nov 2022 21:07:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1669493260; bh=iEkxieBPHa+fHW5sOtdJeA2qnp8SyX/YZwu/Akd9j0s=; h=From:To:Cc:Subject:Date:From; b=JE2c+QF9KcMezuC/IOXoiDb/QoXf1gO/koztGcJBATK+EV8NqVJr0cJSzeCJgHXRp fKLGLbeOe/iLS5MG5Lkz0yGr4r9EsAeHP/sDtAGddFCQ5YlxQowfGu5iIdkII3tyHa E2pwIiU2sjKcdxr1DZJDnH54n/VwC5bGsK0KVJSJZ6QYhuqR8MEFMUoyrA1IrRRhQl CW0PVJvkM9Gye88r4dkKi4z884+18guf9Svnnfjed7xmZI2MJNpRLCBHNx+pUp0n2c vfeJrDvY+o2V0Rj9uMWh0rBGDr02DTis5Rb1em6CKmPdybHOnfXScDY37aWXJy2eM7 8CUMOclQ8wSBw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NKN7c1ZPCz6tmK; Sat, 26 Nov 2022 21:07:37 +0100 (CET) In-Reply-To: <875yfdd5ad.fsf@disroot.org> (Akib Azmain Turja's message of "Thu, 17 Nov 2022 20:28:10 +0600") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300587 Archived-At: --=-=-= Content-Type: text/plain Akib Azmain Turja writes: > Philip Kaludercic writes: > >>>> OK, then adding them to NonGNU ELPA seems like the safer bet. >>>> >>>> I'd like to add them, but I'll have to take the time to review them >>>> first, which might take a bit. >>> >>> What do you want to review? The patches, or the packages? >> >> The packages, unless you aren't interested in comments. > > Review if you wish, I welcome feedback. One minor one more: --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename=comments.diff Content-Transfer-Encoding: quoted-printable diff --git a/minibar.el b/minibar.el index 983b3ff58b..0eb6fd338d 100644 --- a/minibar.el +++ b/minibar.el @@ -137,9 +137,7 @@ a string to display, or nil in case there is to show." ;;;###autoload (define-minor-mode minibar-mode "Toggle Minibar display." - :init-value nil :lighter " Minibar" - :keymap nil :global t (if minibar-mode (progn @@ -450,6 +448,9 @@ when it was recorded.") (lambda (i) (let ((load (minibar--module-cpu-calculate-load (format "cpu%i" i)))) + ;; You should be able to simplify this with an + ;; `alist-get' call and something like #'> as the + ;; equality test. (cond ((and (char-displayable-p ?=E2=96=88) ; #x2588 (>=3D load 87.5)) --=-=-= Content-Type: text/plain The rest looks fine, so I'll push the commits to nongnu.git. --=-=-=--