Re: [NonGNU ELPA] 11 new packages!

[Philip Kaludercic <philipk@posteo.net>]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

Akib Azmain Turja <akib@disroot.org> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>>>> OK, then adding them to NonGNU ELPA seems like the safer bet.
>>>>
>>>> I'd like to add them, but I'll have to take the time to review them
>>>> first, which might take a bit.
>>>
>>> What do you want to review?  The patches, or the packages?
>>
>> The packages, unless you aren't interested in comments.
>
> Review if you wish, I welcome feedback.

One minor one more:


[-- Attachment #2: comments.diff --]
[-- Type: text/x-diff, Size: 844 bytes --]

diff --git a/minibar.el b/minibar.el
index 983b3ff58b..0eb6fd338d 100644
--- a/minibar.el
+++ b/minibar.el
@@ -137,9 +137,7 @@ a string to display, or nil in case there is to show."
 ;;;###autoload
 (define-minor-mode minibar-mode
   "Toggle Minibar display."
-  :init-value nil
   :lighter " Minibar"
-  :keymap nil
   :global t
   (if minibar-mode
       (progn
@@ -450,6 +448,9 @@ when it was recorded.")
                (lambda (i)
                  (let ((load (minibar--module-cpu-calculate-load
                               (format "cpu%i" i))))
+		   ;; You should be able to simplify this with an
+		   ;; `alist-get' call and something like #'> as the
+		   ;; equality test.
                    (cond
                     ((and (char-displayable-p ?█)  ; #x2588
                           (>= load 87.5))

[-- Attachment #3: Type: text/plain, Size: 62 bytes --]


The rest looks fine, so I'll push the commits to nongnu.git.