From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#61601: [PATCH] * lisp/isearch.el (minibuffer-lazy-highlight-setup): Use cursor-in-echo-area Date: Sat, 18 Feb 2023 22:40:13 +0100 Message-ID: <87wn4eodoi.fsf@gmail.com> References: <87edqnyzwl.fsf@gmail.com> <86zg9ake3r.fsf@mail.linkov.net> <83ttziye7z.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10825"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61601@debbugs.gnu.org, Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 18 22:41:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTUxM-0002e5-Sn for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Feb 2023 22:41:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTUx6-0006vQ-Ch; Sat, 18 Feb 2023 16:41:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTUx4-0006v4-R5 for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 16:41:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTUx4-0001uC-Ht for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 16:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTUx4-000389-2m for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 16:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Feb 2023 21:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61601 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61601-submit@debbugs.gnu.org id=B61601.167675642411972 (code B ref 61601); Sat, 18 Feb 2023 21:41:02 +0000 Original-Received: (at 61601) by debbugs.gnu.org; 18 Feb 2023 21:40:24 +0000 Original-Received: from localhost ([127.0.0.1]:45095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTUwR-000372-Uk for submit@debbugs.gnu.org; Sat, 18 Feb 2023 16:40:24 -0500 Original-Received: from mail-ed1-f50.google.com ([209.85.208.50]:33675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTUwQ-00036j-IE for 61601@debbugs.gnu.org; Sat, 18 Feb 2023 16:40:23 -0500 Original-Received: by mail-ed1-f50.google.com with SMTP id dm15so6590952edb.0 for <61601@debbugs.gnu.org>; Sat, 18 Feb 2023 13:40:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=zwR2T+vOTixR0CiDIf8SAzPoau4amTIlaU9pqvammqg=; b=crCcoFAToWBVNk68+wevr/asBnTI4EsbGxf6De0ZXPgpzZXpU/ZTekqz8NYgJtp77w Jz9kAXhzS0rIAHM4ZUJS6OKcN13NhBTM5LPk67dkvfw1Ho6+h6iT9FgHe4uWOs5konZz QLv/AJd50u3GhnsSwoQBMS1J1fRED1zll2HM98fwgiakMRqTZ6hPOPuvdg0NkXcYXnTp aZYEBCK+Ggr9+ylkn3Z5u/lwanFPM90/07HxI8Vn6Y0zDqQ4lRS/5NEaCld2VmYZGW7E WMx9Hd6vGOcTCeFCKeiBXsADv3M9t6gJZDRa7Bs3h+nY88G27oIZv2iJRqqEikGom3v8 14NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zwR2T+vOTixR0CiDIf8SAzPoau4amTIlaU9pqvammqg=; b=Hb48n3gUksG9ol+r0/BF2WnrlC7mQPRvafQUfFFLwO0IkH3H0pOgxwi5G6qsIORfF/ mmWdaXNmh53hAHZ+Bv9OpDlMds1hE63PmU8cZ25AN0QGXakvJRLy+GP8c4BWMkHq00kW Lt909brtgyniexTUCFNxfnLQ8OruH9tV1ucn+3YBWhcDyidtsI5S+3UWpjl0LsXEBfA+ /THNmfhe+cfPdtOoxES8e9a61O9LDQHJbmwV9Dfr+ZcOA2T6nM3WKuoTcW9AooLEThXN Ky4MnFZqtbWui5Wn1+QjqrTK9Udr8jfHu9U2BjnePUXHcgUOLFD2HZz3Z6Xu8/UIkNZk O47w== X-Gm-Message-State: AO0yUKVQ5wr893h3PwwE4D4Q5YR+q/H3N63l/jjfo3B/Vmj1xruC0psD LKEFnlcE6dhSBuJEzoshZbXSoQGHIbmvkA== X-Google-Smtp-Source: AK7set8P6dCEVMj9KGFLnAhQWCspWs/3OfBZuqbkwUdT7zQReD+EY2qdRU7/n1PEfeKfAUBL7c279w== X-Received: by 2002:a05:6402:644:b0:4ac:cb71:42e with SMTP id u4-20020a056402064400b004accb71042emr118914edx.12.1676756415949; Sat, 18 Feb 2023 13:40:15 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::6fd0]) by smtp.gmail.com with ESMTPSA id i20-20020a0564020f1400b004acc6cbc451sm170184eda.36.2023.02.18.13.40.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Feb 2023 13:40:15 -0800 (PST) In-Reply-To: <83ttziye7z.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Feb 2023 21:18:24 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255997 Archived-At: On Sat, 18 Feb 2023 at 21:18, Eli Zaretskii wrote: >> Cc: 61601@debbugs.gnu.org >> From: Juri Linkov >> Date: Sat, 18 Feb 2023 20:44:40 +0200 >> >> > I wasn't aware of the variable cursor-in-echo-area when I originally >> > wrote this function, but it's a much less drastic measure than setting >> > inhibit-redisplay. >> >> I don't know if Eli will allow this to the emacs-29 branch. > > Can you explain how the old and the new code prevent "flickering" in > that place? The flickering happens because the cursor briefly moves from the minibuffer to the minibuffer selected window when the lazy highlighting is done (e.g. after typing a character in the C-M-% regexp query). The previous solution was to inhibit redisplay during that brief period. The new and better solution is to just set cursor-in-echo-area, which does exactly what we want to happen.