all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Augusto Stoffel <arstoffel@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 61601@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#61601: [PATCH] * lisp/isearch.el (minibuffer-lazy-highlight-setup): Use cursor-in-echo-area
Date: Sat, 18 Feb 2023 22:40:13 +0100	[thread overview]
Message-ID: <87wn4eodoi.fsf@gmail.com> (raw)
In-Reply-To: <83ttziye7z.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Feb 2023 21:18:24 +0200")

On Sat, 18 Feb 2023 at 21:18, Eli Zaretskii wrote:

>> Cc: 61601@debbugs.gnu.org
>> From: Juri Linkov <juri@linkov.net>
>> Date: Sat, 18 Feb 2023 20:44:40 +0200
>> 
>> > I wasn't aware of the variable cursor-in-echo-area when I originally
>> > wrote this function, but it's a much less drastic measure than setting
>> > inhibit-redisplay.
>> 
>> I don't know if Eli will allow this to the emacs-29 branch.
>
> Can you explain how the old and the new code prevent "flickering" in
> that place?

The flickering happens because the cursor briefly moves from the
minibuffer to the minibuffer selected window when the lazy highlighting
is done (e.g. after typing a character in the C-M-% regexp query).

The previous solution was to inhibit redisplay during that brief period.
The new and better solution is to just set cursor-in-echo-area, which
does exactly what we want to happen.





  reply	other threads:[~2023-02-18 21:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-18 11:30 bug#61601: [PATCH] * lisp/isearch.el (minibuffer-lazy-highlight-setup): Use cursor-in-echo-area Augusto Stoffel
2023-02-18 18:44 ` Juri Linkov
2023-02-18 19:05   ` Augusto Stoffel
2023-02-18 19:18   ` Eli Zaretskii
2023-02-18 21:40     ` Augusto Stoffel [this message]
2023-02-18 22:43       ` Drew Adams
2023-02-19 12:16         ` Augusto Stoffel
2023-02-19 15:53           ` Drew Adams
2023-02-19  6:16       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn4eodoi.fsf@gmail.com \
    --to=arstoffel@gmail.com \
    --cc=61601@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.