From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61394: 30.0.50; [PATCH] Image-dired thumb name based on content Date: Sun, 19 Feb 2023 15:43:26 +0100 Message-ID: <87wn4dra0h.fsf@ledu-giraud.fr> References: <874jruy7xx.fsf@ledu-giraud.fr> <87ttztk0yw.fsf@tcd.ie> <87v8k9s6j9.fsf@ledu-giraud.fr> <83ilg8jzti.fsf@gnu.org> <87k00oo03r.fsf@ledu-giraud.fr> <838rh4jlsq.fsf@gnu.org> <87bklzol8n.fsf@ledu-giraud.fr> <877cwmo8ij.fsf@ledu-giraud.fr> <87y1oz54bn.fsf@ledu-giraud.fr> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7595"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: contovob@tcd.ie, Eli Zaretskii , 61394@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 19 15:44:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTkvP-0001oL-VZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Feb 2023 15:44:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTkv7-0004Hn-EC; Sun, 19 Feb 2023 09:44:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTkv5-0004HB-BF for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 09:44:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTkv4-0006ST-Mr for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 09:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTkv4-0000R9-5t for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 09:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Feb 2023 14:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61394 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61394-submit@debbugs.gnu.org id=B61394.16768178121622 (code B ref 61394); Sun, 19 Feb 2023 14:44:02 +0000 Original-Received: (at 61394) by debbugs.gnu.org; 19 Feb 2023 14:43:32 +0000 Original-Received: from localhost ([127.0.0.1]:46018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTkua-0000Q4-3K for submit@debbugs.gnu.org; Sun, 19 Feb 2023 09:43:32 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:24306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTkuX-0000Ps-7y for 61394@debbugs.gnu.org; Sun, 19 Feb 2023 09:43:30 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=nSs3qRzh mJ2DaCxNDxrI9vcUAd5J2C3HRsnZmYKtO7w=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=tBJUGN5ghBY8yzLRYOyBoLEHZKCSgF UoEJaKLIwFXySKz2Aye0rBxcfxF68nRa8+OhpwB9Hw1lAxCHRv0pB0BQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=nSs3qRzhmJ2DaCxN DxrI9vcUAd5J2C3HRsnZmYKtO7w=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=nCvx39eYR0kSK6pv5sKV6mpGkQAXJlodWoafJM /yn3TV4iyb6FTbTYtc4/31Nt0rxE0fumOCjq7VopLEwIvOEeei/j9ON0bLMUDm5XHuygxb A1RQ2l9xTZ2uwQckoOLgVsFop0MU3y79N02s2anPZy5WVehoDR8qtbqW1IGjwrtsLSE7VD x4gDnNUsB5g2xoUFTWrHsDo+MPh9W65rt0h4jEH7IvumlBv3FGyduXpsKlSb2xSeZPBrEL 73pNNqBSCY1fudZ+f9HMLuvtp7GQBrR18h/HxzAjbSoMyuLWAYfh5BRvGZDlrGXD8UQe4j bFCM6OGYvhrMiQXFc4rfW79Q== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 1e1ca988 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 19 Feb 2023 15:43:27 +0100 (CET) In-Reply-To: (Stefan Kangas's message of "Sun, 19 Feb 2023 06:06:18 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256074 Archived-At: Stefan Kangas writes: > Manuel Giraud writes: > >>> I think 'image-dired-thumbnail-storage' is already complicated enough, >>> and I'd rather not complicate it further. >> >> I don't understand here. Do you suggest introducing another >> custom/variable? 'image-dired-thumbnail-storage' has currently only 3 >> possible values. I was suggesting adding one more. > > That variable relates to *where* to store the thumbnail files, not how > to name the thumbnail files. I might want to use `image-dired' or > `per-directory' using either thumbnail naming scheme. > > So a new variable makes more sense, as it is orthogonal from > `image-dired-thumbnail-storage'. > >>> Hmm, it sounds a bit too nondescript. How about something like >>> 'image-dired-thumbnail-naming'? >> >> Do you mean as a name for a new variable? (I was talking about a new >> possible value for image-dired-thumbnail-storage) > > Yes. However, we currently have `image-dired-thumb-size', so perhaps > `image-dired-thumb-naming' is better. Ok. I like that. I'll try to come up with something but I think I'll do some cleaning in the process as currently 'image-dired-thumbnail-storage' decides more than just the "where" (eg. add "thumb" somewhere). -- Manuel Giraud