From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#62417: ; Regression: 59ecf25fc860 is the first bad commit Date: Sun, 26 Mar 2023 21:23:08 +0000 Message-ID: <87wn331a2r.fsf@posteo.net> References: <87sfducmrc.fsf@gmail.com> <87o7oicgy4.fsf@gmail.com> <87wn365e3t.fsf@posteo.net> <87pm8yaq24.fsf_-_@gmail.com> <83fs9tc7o9.fsf@gnu.org> <83cz4xc6hg.fsf@gnu.org> <83zg80c40u.fsf@gnu.org> <87a5zzuutl.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18383"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 62417@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 26 23:24:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgXqY-0004TS-VK for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Mar 2023 23:24:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgXqO-0000yX-1X; Sun, 26 Mar 2023 17:24:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgXqN-0000yO-5B for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 17:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgXqM-0005Sv-U3 for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 17:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pgXqM-0007Xt-Aq for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 17:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Mar 2023 21:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62417 X-GNU-PR-Package: emacs Original-Received: via spool by 62417-submit@debbugs.gnu.org id=B62417.167986579828950 (code B ref 62417); Sun, 26 Mar 2023 21:24:02 +0000 Original-Received: (at 62417) by debbugs.gnu.org; 26 Mar 2023 21:23:18 +0000 Original-Received: from localhost ([127.0.0.1]:46001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgXpd-0007Wp-WF for submit@debbugs.gnu.org; Sun, 26 Mar 2023 17:23:18 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:35443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgXpb-0007Wb-94 for 62417@debbugs.gnu.org; Sun, 26 Mar 2023 17:23:16 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 6D5A92401A5 for <62417@debbugs.gnu.org>; Sun, 26 Mar 2023 23:23:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1679865789; bh=FuqYVlhklFHjex+J06ufC+OIMoaJYEYYNdOjzyYmkyU=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=gD1/9DbAt4KuP1i+QBua7RPHdwAfWlIRdzleV/SDgAc9nh0cHHMDiUtnnmejRKYmK fcqYV7oATTUtLZi3tKjm9RPfimmRCUOib7+9Hy+y3bAu3quD6MmhWOaDssVnuVXN1H l3c3HP7UEjGCvoPH0BRbi2BnWLadpaVBf52/t9m0Y9MGEShaFd/fw2DAHITA7YXdr+ HeoL7ICJexj5Sy4xgNMtSFNhEOSy384AkCMSqBoyJ2d+TUDlLjK8DfZaUrs2jwbgDa /ihgFs/M7VyomJSkm4fjOmxbBzXhqpCvIFbJWJSNuvI8j0cLRdZYDoOA+RQ74TEANl orZwhgOpcpAAA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Pl87J5Vp1z6tmx; Sun, 26 Mar 2023 23:23:08 +0200 (CEST) In-Reply-To: <87a5zzuutl.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 26 Mar 2023 21:22:14 +0100") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258700 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > Eli Zaretskii writes: > >>> From: Jo=C3=A3o T=C3=A1vora >>> Date: Sat, 25 Mar 2023 13:56:40 +0000 >>> Cc: "Philip K." , 62417@debbugs.gnu.org >>>=20 >>> But you're confused: this is not about buffer-match-p's arguments. It's= about the arguments to the function >>> that you may also pass to buffer-match-p in it's first CONDITION argume= nt. Use my simple recipe in both >>> Emacs 28 and 29. >> >> The function should be called with the same BUFFER-OR-NAME argument >> with which buffer-match-p was called. > > Here's your idea in a patch. It fixes the issue. Propose this be > pushed to emacs-29. > > Jo=C3=A3o > > diff --git a/lisp/subr.el b/lisp/subr.el > index 99ddd813867..39866dd7acb 100644 > --- a/lisp/subr.el > +++ b/lisp/subr.el > @@ -7114,7 +7114,7 @@ buffer-match-p > - the symbol t, to always match, > - the symbol nil, which never matches, > - a regular expression, to match a buffer name, > -- a predicate function that takes a buffer object and ARG as > > +- a predicate function that takes BUFFER-OR-NAME and ARG as > arguments, and returns non-nil if the buffer matches, > - a cons-cell, where the car describes how to interpret the cdr. > The car can be one of the following: > @@ -7140,8 +7140,8 @@ buffer-match-p > (string-match-p condition (buffer-name buffer))) > ((pred functionp) > (if (eq 1 (cdr (func-arity condition))) > - (funcall condition buffer) > - (funcall condition buffer arg))) > + (funcall condition buffer-or-name) > + (funcall condition buffer-or-name arg))) > (`(major-mode . ,mode) > (eq > (buffer-local-value 'major-mode buffer) > diff --git a/lisp/window.el b/lisp/window.el > index 08ce8498655..e8daa0383ec 100644 > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -7510,8 +7510,8 @@ display-buffer-alist > If non-nil, this is an alist of elements (CONDITION . ACTION), > where: >=20=20 > - CONDITION is passed to `buffer-match-p', along with the buffer > - that is to be displayed and the ACTION argument of > + CONDITION is passed to `buffer-match-p', along with the name of > + the buffer that is to be displayed and the ACTION argument of > `display-buffer', to check if ACTION should be used. >=20=20 > ACTION is a cons cell (FUNCTIONS . ALIST), where FUNCTIONS is an LGTM --=20 Philip Kaludercic