all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tony Zorman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 63541@debbugs.gnu.org, Steven Allen <steven@stebalien.com>
Subject: bug#63541: [PATCH] ; Fix use-package :vc keyword when byte-compiled
Date: Fri, 19 May 2023 17:16:20 +0200	[thread overview]
Message-ID: <87wn14wdvf.fsf@hyperspace> (raw)
In-Reply-To: <87a5y1za7p.fsf@posteo.net>

On Thu, May 18 2023 19:54, Philip Kaludercic wrote:
> Steven Allen <steven@stebalien.com> writes:
>
>> * lisp/use-package/use-package-core.el (use-package-handler/:vc):
>> Return the new 'body'. Otherwise, the entire package declaration gets
>> dropped when byte-compiling.
>> ---
>>  lisp/use-package/use-package-core.el | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/lisp/use-package/use-package-core.el b/lisp/use-package/use-package-core.el
>> index 0d99e270a3f..e0e16134ed3 100644
>> --- a/lisp/use-package/use-package-core.el
>> +++ b/lisp/use-package/use-package-core.el
>> @@ -1619,7 +1619,8 @@ defvar use-package--form)
>>      ;; See `use-package-handler/:ensure' for an explanation.
>>      (if (bound-and-true-p byte-compile-current-file)
>>          (funcall #'use-package-vc-install arg local-path)        ; compile time
>> -      (push `(use-package-vc-install ',arg ,local-path) body)))) ; runtime
>> +      (push `(use-package-vc-install ',arg ,local-path) body))   ; runtime
>> +    body))
>>  
>>  (defun use-package-normalize--vc-arg (arg)
>>    "Normalize possible arguments to the `:vc' keyword.
>
> CC'ing Tony, since he did most of the work here.  Do you have any
> comments on this change?

Looks fine to me; @Steven thanks for catching this! Seems like I wasn't
careful enough when testing with a byte compiled file.

I'm not super familiar with the testing infrastructure here, but I
wonder whether there is an easy way to write a quick regression test for
this?

-- 
Tony Zorman | https://tony-zorman.com/





  reply	other threads:[~2023-05-19 15:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16 23:12 bug#63541: [PATCH] ; Fix use-package :vc keyword when byte-compiled Steven Allen
2023-05-18 19:54 ` Philip Kaludercic
2023-05-19 15:16   ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-05-20 16:50     ` Philip Kaludercic
2023-05-21  9:32       ` Tony Zorman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-26  4:54         ` Steven Allen
2023-05-31 13:23           ` Eli Zaretskii
2023-05-31 21:53             ` Philip Kaludercic
2023-06-03  7:28               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn14wdvf.fsf@hyperspace \
    --to=bug-gnu-emacs@gnu.org \
    --cc=63541@debbugs.gnu.org \
    --cc=philipk@posteo.net \
    --cc=soliditsallgood@mailbox.org \
    --cc=steven@stebalien.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.