From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#63916: 30.0.50; use-package: changes do not propagate to elpa-devel Date: Sun, 11 Jun 2023 10:34:27 +0000 Message-ID: <87wn0a2sp8.fsf@posteo.net> References: <4b1ff1660351348f3d5f1bc848965d59@orthen.net> <874jnf3d0c.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24351"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Benjamin Orthen , 63916@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 11 12:36:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8IQm-00069T-N9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Jun 2023 12:36:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q8IPY-0006Zh-LR; Sun, 11 Jun 2023 06:35:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8IPX-0006ZZ-0a for bug-gnu-emacs@gnu.org; Sun, 11 Jun 2023 06:35:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q8IPW-0008O3-GS for bug-gnu-emacs@gnu.org; Sun, 11 Jun 2023 06:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q8IPV-0004ON-RV for bug-gnu-emacs@gnu.org; Sun, 11 Jun 2023 06:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Jun 2023 10:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63916 X-GNU-PR-Package: emacs Original-Received: via spool by 63916-submit@debbugs.gnu.org id=B63916.168647968216853 (code B ref 63916); Sun, 11 Jun 2023 10:35:01 +0000 Original-Received: (at 63916) by debbugs.gnu.org; 11 Jun 2023 10:34:42 +0000 Original-Received: from localhost ([127.0.0.1]:36763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8IP9-0004Ni-Dp for submit@debbugs.gnu.org; Sun, 11 Jun 2023 06:34:42 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:59931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8IP4-0004NN-Db for 63916@debbugs.gnu.org; Sun, 11 Jun 2023 06:34:38 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 2F3AB240027 for <63916@debbugs.gnu.org>; Sun, 11 Jun 2023 12:34:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1686479668; bh=Oz4lkAwp/It+vgZRTM41rzytNEpf+wdQ07czwKtxCLk=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=Qiv51Y3hdXMp2T+J9rew902rCR7qUnXz+MSj81hgZR+IRRobD38j5uoPsfaYh2zDY IpXOJKbxcdImhilui28RJU2bIWPNpZDGulPbF2pg7BUZxd7wDUiq+vjPG0t5NJOSbd uKGx7m8xzXS+W0/F3dMBkaPsN+4NzlTy6zuOm9F5dkA30JZ3y0s2Q6ffs+rTijtAwY Zpqh4IloCX+uD+F9EO1ysFSF8Xy5Pl65LMX75J+Mw1s6RJXNgu8YfIfrsrsksoOopS mk3+poqsZW34GuEW7rfFjLGAcfrKUF26DnbjeTQVk1zKpv7PmvuFk5BcyCk8aHtS0D Pes9wQ3Y8O8+g== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QfB5H3cHMz6tvq; Sun, 11 Jun 2023 12:34:27 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Sat, 10 Jun 2023 12:01:04 -0400") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263243 Archived-At: Stefan Monnier writes: >> But if I disable sandboxing, then it works. The issue appears to be >> that the files under package/use-package are linked in using symlinks, >> but the directory (the emacs checkout) that is being linked to is not >> exposed via bwarp. If I add that to the ro-binds, then I can build the >> package. This diff might be enough to resolve the issue: >> >> diff --git a/elpa-admin.el b/elpa-admin.el >> index 24dd16d3cb..81467aa628 100644 >> --- a/elpa-admin.el >> +++ b/elpa-admin.el >> @@ -1262,7 +1262,8 @@ The INFILE and DISPLAY arguments are fixed as nil." >> "--tmpfs" "/tmp")) >> >> (defvar elpaa--sandbox-ro-binds >> - '("/lib" "/lib64" "/bin" "/usr" "/etc/alternatives" "/etc/emacs" "/gnu")) >> + `("/lib" "/lib64" "/bin" "/usr" "/etc/alternatives" "/etc/emacs" "/gnu" >> + ,(file-truename (expand-file-name "emacs")))) > [...] >> CC: Stefan, does this look OK to you? > > Building of :core packages outside of `elpa.gnu.org` is indeed tested on > very lightly. In `elpa.gnu.org`, the `emacs` subdirectory is not > a symlink so we avoid that problem. OK, I forgot that I added the symlink. > The above patch feels a bit hackish because it depends on the > directory that happens to be current when the file is loaded. I agree, that could be made more robust but isn't elpa-admin.el always invoked via make? > BTW, you should be able to make the current code work without changing > it, by adding > > (sandbox-extra-ro-dirs "/where/ever/your/emacs/source/dir/is") > > to the `elpa-config` file. Of course, that was my first idea but I wanted to find a solution that wouldn't require every user to manually configure this, since the error message does not make it obvious what went wrong. > > Stefan > -- Philip Kaludercic