all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: monnier@iro.umontreal.ca, 64596@debbugs.gnu.org
Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update)
Date: Wed, 19 Jul 2023 10:11:19 +0000	[thread overview]
Message-ID: <87wmyww6rc.fsf@localhost> (raw)
In-Reply-To: <83cz0p780j.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> I saw this. But "update" is not used consistently across that
>> commentary.
>
> Tough.  "Update" is too general a word to limit is use.  Sorry.

May it be replaced by another, more precise, term then?

>> If we read at the very beginning:
>> 
>>     /* New redisplay written by Gerd Moellmann <gerd@gnu.org>.
>>     
>>        Redisplay.
>>     
>>        Emacs separates the task of updating the display from code
>>        modifying global state, e.g. buffer text. ...
>>     
>>        Updating the display is triggered by the Lisp interpreter when it
>>        decides it's time to do it....
>> 
>> Which immediately creates an impression that "redisplay" and "update"
>> are referring to the same thing.
>
> There's no practical way to avoid all the possible misinterpretations
> of this large and complex text, especially when it is read for the
> first time.

What about the attached patch?

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-src-xdisp.c-Clarify-the-meaning-of-update-term-in-co.patch --]
[-- Type: text/x-patch, Size: 1331 bytes --]

From 2be256093307246f8a3a62a5613467ceb6e7e9b8 Mon Sep 17 00:00:00 2001
Message-ID: <2be256093307246f8a3a62a5613467ceb6e7e9b8.1689761362.git.yantar92@posteo.net>
From: Ihor Radchenko <yantar92@posteo.net>
Date: Wed, 19 Jul 2023 13:08:54 +0300
Subject: [PATCH] * src/xdisp.c: Clarify the meaning of "update" term in
 commentary

See bug#64596.
---
 src/xdisp.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/xdisp.c b/src/xdisp.c
index a3464c2c375..b306159c2f9 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -75,6 +75,13 @@ Copyright (C) 1985-2023 Free Software Foundation, Inc.
    and to make these changes visible.  Preferably it would do that in
    a moderately intelligent way, i.e. fast.
 
+   To be as fast as possible, redisplay code tries hard to avoid
+   updating unchanged parts of the display on the glass.  Redisplay
+   process starts from examining what has been changed since the
+   previous redisplay and only running the glass _update_ action when
+   necessary.  In the code below, functions and variables related to
+   updating on the glass will have _update_ in their names.
+
    Changes in buffer text can be deduced from window and buffer
    structures, and from some global variables like `beg_unchanged' and
    `end_unchanged'.  The contents of the display are additionally
-- 
2.41.0


[-- Attachment #3: Type: text/plain, Size: 224 bytes --]


-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

  reply	other threads:[~2023-07-19 10:11 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13 13:00 bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Ihor Radchenko
2023-07-13 13:34 ` Eli Zaretskii
2023-07-13 17:19   ` Ihor Radchenko
2023-07-13 19:03     ` Eli Zaretskii
2023-07-14 11:53   ` Ihor Radchenko
2023-07-14 12:25     ` Eli Zaretskii
2023-07-14 13:48       ` Ihor Radchenko
2023-07-14 14:20         ` Eli Zaretskii
2023-07-14 14:50       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-14 14:20     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-14 15:56       ` Eli Zaretskii
2023-07-13 17:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-13 19:08   ` Eli Zaretskii
2023-07-13 21:00     ` Ihor Radchenko
2023-07-13 22:02     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-14  6:14       ` Eli Zaretskii
2023-07-14 14:31         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-14 16:00           ` Eli Zaretskii
2023-07-14 17:38             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-14 17:46               ` Ihor Radchenko
2023-07-14 19:06                 ` Eli Zaretskii
2023-07-15  7:01                   ` Eli Zaretskii
2023-07-15  7:22                     ` Ihor Radchenko
2023-07-15  8:52                       ` Eli Zaretskii
2023-07-15 14:49                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-15 15:22                       ` Eli Zaretskii
2023-07-15 16:01                         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-15 16:16                           ` Eli Zaretskii
2023-07-15 17:15                             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-15 19:04                               ` Eli Zaretskii
2023-07-16 10:38                               ` Ihor Radchenko
2023-07-16 11:26                                 ` Eli Zaretskii
2023-07-15 18:15                             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-15 19:18                               ` Eli Zaretskii
2023-07-15 19:28                               ` Eli Zaretskii
2023-07-15 19:43                                 ` Ihor Radchenko
2023-07-15 23:10                                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-16  4:57                                   ` Eli Zaretskii
2023-07-16  5:49                                     ` Ihor Radchenko
2023-07-16  7:15                                       ` Eli Zaretskii
2023-07-16  8:26                                     ` martin rudalics
2023-07-16  8:40                                       ` Ihor Radchenko
2023-07-16  8:56                                         ` Eli Zaretskii
2023-07-16  9:41                                           ` Ihor Radchenko
2023-07-16 10:30                                             ` Eli Zaretskii
2023-07-16  8:50                                       ` Eli Zaretskii
2023-07-17  8:30                                         ` martin rudalics
2023-07-15 22:53                                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-16  5:17                                   ` Eli Zaretskii
2023-07-16  5:52                                   ` Ihor Radchenko
2023-07-16  7:16                                     ` Eli Zaretskii
2023-07-16  7:28                                       ` Ihor Radchenko
2023-07-16  7:35                                         ` Eli Zaretskii
2023-07-16 14:04                                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-16 14:27                                       ` Eli Zaretskii
2023-07-16 14:49                                         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-16 10:22                       ` Ihor Radchenko
2023-07-16 10:37                         ` Eli Zaretskii
2023-07-16 10:47                           ` Ihor Radchenko
2023-07-16 11:31                             ` Eli Zaretskii
2023-07-16 14:26                             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-16 14:45                               ` Eli Zaretskii
2023-07-16 16:44                                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-16 17:11                                   ` Eli Zaretskii
2023-07-16 17:20                                     ` Eli Zaretskii
2023-07-16 18:53                                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-16 19:06                                       ` Eli Zaretskii
2023-07-16 22:19                                         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-17 11:20                                           ` Eli Zaretskii
2023-07-17 12:53                                             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-17 13:07                                               ` Eli Zaretskii
2023-07-16 19:27                         ` Eli Zaretskii
2023-07-16 20:12                           ` Ihor Radchenko
2023-07-17  2:23                             ` Eli Zaretskii
2023-07-17  9:22                               ` Ihor Radchenko
2023-07-17 11:54                                 ` Eli Zaretskii
2023-07-17 12:00                                   ` Ihor Radchenko
2023-07-17 12:22                                     ` Eli Zaretskii
2023-07-18  9:52                                       ` Ihor Radchenko
2023-07-18 11:51                                         ` Eli Zaretskii
2023-07-19 10:11                                           ` Ihor Radchenko [this message]
2023-07-19 14:55                                             ` Eli Zaretskii
2023-07-19 15:50                                               ` Ihor Radchenko
2023-07-19 16:30                                                 ` Eli Zaretskii
2023-07-20  9:40                                                   ` Ihor Radchenko
2023-07-20 10:23                                                     ` Eli Zaretskii
2023-07-21  2:41                                         ` Richard Stallman
2023-07-21  5:48                                           ` Eli Zaretskii
2023-07-23  3:01                                             ` Richard Stallman
2023-07-14 19:05               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmyww6rc.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=64596@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.