From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 400df210ce0: Fix last change of 'delete-file' Date: Thu, 10 Aug 2023 16:41:01 +0200 Message-ID: <87wmy355aa.fsf@gmail.com> References: <169133064669.24990.11219399079845613336@vcs2.savannah.gnu.org> <20230806140407.09E6BC038BE@vcs2.savannah.gnu.org> <875y5n6nz2.fsf@gmail.com> <83o7jfhvw3.fsf@gnu.org> <871qgb6mg9.fsf@gmail.com> <83h6p7hueg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1299"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 10 16:41:48 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qU6rE-0000Ba-9o for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Aug 2023 16:41:48 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qU6qb-0007kI-Of; Thu, 10 Aug 2023 10:41:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qU6qZ-0007ju-9U for emacs-devel@gnu.org; Thu, 10 Aug 2023 10:41:07 -0400 Original-Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qU6qX-0000vs-Ox; Thu, 10 Aug 2023 10:41:07 -0400 Original-Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3fe82a7873fso922825e9.3; Thu, 10 Aug 2023 07:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691678464; x=1692283264; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=uC4iDahPm6bBUmgloOjJjlkIm0iCNX+FuruizymsHX8=; b=WLezjMjG7G9JreEP5ClQN0bKSgemR2yvjRG/gB5qpJCgVKey/RkhWL5E1ZE6G8Wu7g GgIfOFv3Tso1T2kB3OQ4N3Q8QKXGk0OGNBBgBzdrCwAXv3a45Hsa9KvAJI4BqCqf3Uee GpisycgtxOB/UPVATHQ5F9vxByQrGvz+jcFQovTlpaOJWXms32oQPuCe4UU+ZUEkYn/a 27Y6O83orAoIXYIWa9MywMDZl3Jtsx3GLWFGsl4od8JwAqUnqbNZkHNt2F9AupAeN/hO ADj2y8yGb4rOAGyqRmjA3GywvVmnyuslg4//ut7OF+HTO3HuJaJqwSyp1FPYHMwfJFBP n44g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691678464; x=1692283264; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uC4iDahPm6bBUmgloOjJjlkIm0iCNX+FuruizymsHX8=; b=O7rkBl6iVMKAWeCSMXb06EYaZ1LCDtiyEbGchtU4quSYsLWeDCbnpNw/uso/f58tlY VCD//8ZkFhPeU6q3AUAiAp8UbQPxF4/iTu433xMNWRJ5RjJC4GOFfkDJDzAX2Q9mZY3l vhGHyMyaKTICdYWehVYPBfdlXWmXSlEpXU02dLSZAA0z+39syazniaD//KqaZYXMMFrI EZuArOxZn4yRmo3S/4p+dXvrgEGon598XzeekUWc9Kq4WGE2HMQwkiG16IxKEJRICo0G NspqEocYmpYj8M6wMfiG/VvFwbTPN0sVT94zhM/c/t97KioecA2cf3++qm7QjAcigRm/ 4jgQ== X-Gm-Message-State: AOJu0Yx4/7R4gHJxKp0IlQHcjQZJ7DryF2eVwBO8/975Fn6eGdYfl7y5 SInBHUjhHW8mwJd8KpkKDAA6+7ASX8g= X-Google-Smtp-Source: AGHT+IHG7Y1W5HCO6JwMk9oxlAZz43jRzc/Ds/aYH2QUCnQs2QKKL2dZzw7SjwrU8rcrRKiarPzt3A== X-Received: by 2002:adf:dd85:0:b0:314:3985:b291 with SMTP id x5-20020adfdd85000000b003143985b291mr2206916wrl.15.1691678463423; Thu, 10 Aug 2023 07:41:03 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:b086:92d7:f1ed:48e0]) by smtp.gmail.com with ESMTPSA id e10-20020adfe7ca000000b0031784ac0babsm2382403wrn.28.2023.08.10.07.41.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 07:41:02 -0700 (PDT) In-Reply-To: <83h6p7hueg.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 10 Aug 2023 16:57:43 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308537 Archived-At: >>>>> On Thu, 10 Aug 2023 16:57:43 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: emacs-devel@gnu.org >> Date: Thu, 10 Aug 2023 15:44:54 +0200 >>=20 >> >>>>> On Thu, 10 Aug 2023 16:25:32 +0300, Eli Zaretskii said: >>=20 >> >> I don=CA=BCt know if it matters, but along with esr=CA=BCs change= this means we >> >> now use the unexpanded file name for eg `find-file-name-handler' >>=20 Eli> All file handlers are perfectly equipped to deal with unexpanded f= ile Eli> names. It must be so, don't you agree? Because if it wasn't, how Eli> could file operations deal with relative file names? >>=20 >> I was thinking of the opposite case, where someone has a personal fi= le >> handler with a regexp with an absolute path in it. Eli> That'd be a buggy file handler, I think, unless it also checks Eli> default-directory. The file handler isn=CA=BCt buggy: it never gets a chance to run. Let me illustrate. Suppose we have an entry of ("\\`/var/.*\\.txt" . my-file-handler) in `file-name-handler-alist'. (delete-file "foo.txt") when `default-directory' is "/var" would previously result in `my-file-handler' being called. Now it=CA=BCs not called at all, and the deletion is handled by `delete-file-internal' Robert --=20