From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: New Package for NonGNU-ELPA: clojure-ts-mode Date: Sat, 12 Aug 2023 20:31:20 +0000 Message-ID: <87wmy080kn.fsf@posteo.net> References: <87il9kksqz.fsf@dfreeman.email> <87a5uw9ivs.fsf@posteo.net> <87ttt42gna.fsf@dfreeman.email> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7802"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel , Manuel Uberti To: Danny Freeman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 12 22:32:16 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUvHT-0001ld-K8 for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Aug 2023 22:32:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUvGh-0001sN-V0; Sat, 12 Aug 2023 16:31:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUvGh-0001sE-0c for emacs-devel@gnu.org; Sat, 12 Aug 2023 16:31:27 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUvGe-00084s-Mh for emacs-devel@gnu.org; Sat, 12 Aug 2023 16:31:26 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 7BBAF24002A for ; Sat, 12 Aug 2023 22:31:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1691872282; bh=M7gf6ggNwtoUgD3b0ZgBSelaBT7Cxin2ln0gecYKM0I=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=XJZUFgsMAyKgBTBBmT6QYzYjXVEQGGFusk/g60u4IoIgq93oGUzSvPYyxJsBACAWR eU/mpTcgJ1/+EIpOdoIX3zZh87bfsD3pJ9zrUHrKmfX0S4Ol0wDBR3SbE/DqQnpwo2 KTwSjVYN9wI4FL4yP0IViFNqaYmwXj0d9wIy9dF173tBiv6rNDJgNszdZ53sqhJMzP 1h0GsqkP5anFl1NDiasQs99w0wTmKV/eQlXDxWIhf+SZseKocvSATK6C27CWSmudAq TzzUH+J+k7TdXIsceayYu8p4fO3URWuhFi0ccZZ+VBGjrtujeD4kywVNdi1GskjMw7 kjhp+rR98dm0A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RNXPP177kz9rxG; Sat, 12 Aug 2023 22:31:21 +0200 (CEST) In-Reply-To: <87ttt42gna.fsf@dfreeman.email> (Danny Freeman's message of "Sat, 12 Aug 2023 15:12:21 -0400") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308632 Archived-At: Danny Freeman writes: > Philip Kaludercic writes: > >> Is there a reason we wouldn't want to have support in the core? Or at >> least GNU ELPA? > > Not all of the maintainers of clojure-mode and clojure-ts-mode are on > board with the core development model, particularly copyright > assignment. Initially I wanted to put this straight in the core but > after some discussion we decided not to. I have personally done my > copyright assignment, but for clojure-ts-mode we won't be asking > contributors for it. Therefore, going into GNU ELPA or core then is out > of the question. That is a pity. IIRC there is a SLIME-like environment for Clojure, right? I don't know if Emacs is also the conventional default environment for working with the language, but if it is, it seems like it would be a nice thing to have at least some basic support in the core :/ Did the discussions on not wanting to contribute anything to the core take place in some public channel, where one could read up on what the issues were or clarify some misunderstandings, in case these occurred? >> If added to GNU ELPA and NonGNU ELPA, this would be the first *-ts-mode >> package, from what I see. From what I recall, the -ts-mode approach was >> a compromise to add some basic support for Tree Sitter in Emacs 29, but >> I am not sure if it was a final decision on the matter, because at least >> from my perspective of following the tree sitter development from a >> close distance, but also from user reports I have heard of since the >> release of Emacs 29, the current approach is slightly confusing. Adding >> a -ts-mode to ELPA might be misinterpreted as a commitment to the >> current trajectory, and I am not sure if that is intended. > > Yeah it is kind of confusing but I'm not sure what the end game is for > all the other *-ts-modes. Non tree-sitter Clojure-mode itself has a lot > of features and is also depended on by some other packages (cider, > inf-clojure). In that regard, we decided trying to keep clojure-ts-mode > and clojure-mode in the same repo would be too complex of a task. > Therefore we put it in it's own repo. > > Very long term plans are for clojure-ts-mode to eventually reach feature > parity with clojure-mode and start making it's consumer packages also > use it. That will probably take a number of years though. So you can also confirm Eli's take, that it is unfeasible to merge the two major modes? >>> + (clojure-ts-mode :url "https://github.com/clojure-emacs/clojure-ts-mode" >>> + :ignored-files ("doc" "test") >> >> If possible, it is preferable to list ignored files in a .elpaignore >> file, in the repository root directory. > > I have made a commit to the repo including one of those .elpaignores. > I'm going to wait a while to tag a new release in case there is other > feedback though. Here is the revised patch I don't think there is much left that can be changed any more, just keep in mind that ELPA doesn't use tags to designate package releases, but it consults Git to detect the latest commit to modify the ";; Version:" tag in the package header.