From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Distopico Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] New package: flymake-guile Date: Thu, 31 Aug 2023 11:13:54 -0500 Message-ID: <87wmxbgpe0.fsf@riseup.net> References: <87a5u7j55e.fsf@riseup.net> <4ce3eb06-31b7-02c9-c624-6b5b30070f66@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36473"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Mauro Aranda Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 31 18:17:23 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbkMC-000988-KA for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Aug 2023 18:17:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbkKm-00049r-0l; Thu, 31 Aug 2023 12:15:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbkKi-000497-Av for emacs-devel@gnu.org; Thu, 31 Aug 2023 12:15:48 -0400 Original-Received: from mx1.riseup.net ([198.252.153.129]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbkKf-0002at-Qy for emacs-devel@gnu.org; Thu, 31 Aug 2023 12:15:48 -0400 Original-Received: from fews01-sea.riseup.net (fews01-sea-pn.riseup.net [10.0.1.109]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx1.riseup.net (Postfix) with ESMTPS id 4Rc5qG64MBzDrlB; Thu, 31 Aug 2023 16:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1693498544; bh=PdibVw81hKH3/1rb386egX+RYAK2gbf8wtwCjmU02rk=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=VQRLWL38+rW7nFMYtzZaiMjTS0ILwLecHjpJjL5fpkdX7ghhl4VJ0/WBWvmTdr1ze 2zkL7Ovm/dhk3RKmvGTI8+AWbRt1OhaLjV0mpCXhdjI3/syW9uoAHxW97rlPjfwg3+ iKoA+y8NOgxKN1rsP6zcUM1KHrWunIpWj8zhW4YM= X-Riseup-User-ID: 1BA81F8D7883F445F7136DCFFD6C3A545300E7285D428393E02F16067A8EC3E5 Original-Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews01-sea.riseup.net (Postfix) with ESMTPSA id 4Rc5pf0ZCKzJntb; Thu, 31 Aug 2023 16:14:49 +0000 (UTC) In-reply-to: <4ce3eb06-31b7-02c9-c624-6b5b30070f66@gmail.com> Received-SPF: pass client-ip=198.252.153.129; envelope-from=distopico@riseup.net; helo=mx1.riseup.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309677 Archived-At: --=-=-= Content-Type: text/plain Hi Mauro, thank for your feedback. On 2023-08-31, Mauro Aranda wrote: > On 30/8/23 23:23, Distopico wrote: >> Hi all! >> >> I'm the author of a new package `flymake-guile` and I >> would like to include it in Nongnu ELPA. >> >> Here the repo: https://framagit.org/flymake-backends/flymake-guile >> >> --8<---------------cut here---------------start------------->8--- >> ;;; Commentary: >> >> ;; Flymake backend for GNU Guile using `guild' compile. >> ;; >> ;; Usage: >> ;; (require 'flymake-guile) >> ;; (add-hook 'scheme-mode-hook 'flymake-guile) >> --8<---------------cut here---------------end--------------->8--- >> >> Best! >> > > Hi, > > I've got a couple of comments about the defcustoms: > > (defcustom flymake-guile-guild-args nil > "Additional arguments for `guild' compile command." > :type 'string > :group 'flymake-guile) > > Looks like either type should allow the nil value, or the default value > should be changed to a string. > > > (defcustom flymake-guile-warnings '("3") > "A list of warnings to enable for `guild compile'. > > The value of this variable could be an list string of warning types > or an warning level. > > The list of supported warning types/levels can be found by running > `guild compile -W help'." > :type '(string) > :group 'flymake-guile) > > It looks like you want the :type to be a list of strings. In that case > you should use (repeat string) as the :type. I updated the code changing these, you can check the repo again and will contain these changes. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFJBAEBCAAzFiEEvYwofabWO6y953lVmAk6gHJUa/MFAmTwvHcVHGRpc3RvcGlj b0ByaXNldXAubmV0AAoJEJgJOoByVGvzoFcIAIodeCoMOad35V9l/SWLAsMIBEgi i1P7VLatdX8R9c6BuFkgrpFq2oD6hARen4LhgO1gOhhR/tr8qnH3fGSI3+mCnd0N JyhVaJQ6AtbiVrLdUejVZPGgq/EVuxtMVua2VsgVoGu42CLC9iRoakdgU3BvLc3/ UCilbvFg/uTvR2ry+en7BfqsrX4O6kzMAOI0YTSqroL6K3sPvxLj/rZfCp2G3xsY CHeGNO7Cv57UXkz33KYYA7Cmejf5qLdTzca9BMhkswLJo4opmG9f7M1FIsAp0+az lqrdWVTNgC3t+mNa4tolDc3BG651stDBgLarrgdo6HjQzrw1WHYdmP+nwxk= =V9zn -----END PGP SIGNATURE----- --=-=-=--