From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/helm 07dacfe2e2 08/11: Prefer string-match-p over string-suffix-p Date: Thu, 14 Sep 2023 13:06:47 +0000 Message-ID: <87wmwsoqe0.fsf@posteo.net> References: <169468919249.10884.8856179202519044902@vcs2.savannah.gnu.org> <20230914105954.20BD1C051D0@vcs2.savannah.gnu.org> <875y4dosa4.fsf@posteo.net> <83wmwslxlc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14791"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, thievol@posteo.net To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 14 15:07:56 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qgm4Z-0003ch-MG for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Sep 2023 15:07:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgm3h-000296-17; Thu, 14 Sep 2023 09:07:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgm3c-00028I-0v for emacs-devel@gnu.org; Thu, 14 Sep 2023 09:06:56 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgm3Y-0006Tr-DI for emacs-devel@gnu.org; Thu, 14 Sep 2023 09:06:55 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id A604C240028 for ; Thu, 14 Sep 2023 15:06:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1694696808; bh=uYL9+P2yxlGHNgk7WSVhAAHe7pyTs26PJMM5HGXA1Yg=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=MDbEUDoGnzWKmAxjgzzJa7G4XqARuxOjLhxZwy551bBQ64xk9AyD5oWlU2Y29osAu +KwVay+N1YPiA/X9odaeGlucOBa/vGnYgr3IGtrP5wFLNJvqhvPa1Pjzcib/R/lqnA np1kP033YbgTD0bfAl7X/N1AI842MEep9J1EB8jH+ilmN7gFc9agk+SrsoXGHTsGUU vUU1TSKp3UCzhdy+OPqME3GVbS+T0V722OusLrJXv90ZUBSXH/gLR3CVGc9AMriJQG Q8+hb14yyxDM94FhJWpJKgo+Q7jcA6n1j0qNXXU3Wb9DiLQAiwMynJmmw67iFELqjv cSsgJuwi7VFSw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RmczD1zCmz6txX; Thu, 14 Sep 2023 15:06:48 +0200 (CEST) In-Reply-To: <83wmwslxlc.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Sep 2023 15:59:27 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310574 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: Thierry Volpiatto >> Date: Thu, 14 Sep 2023 12:25:55 +0000 >> >> ELPA Syncer writes: >> >> > --- a/helm-lib.el >> > +++ b/helm-lib.el >> > @@ -1732,7 +1732,7 @@ Directories expansion is not supported." >> > (with-temp-buffer >> > (call-process-shell-command >> > (format cmd >> > - (if (string-suffix-p ".gz" file) >> > + (if (string-match-p ".gz\\'" file) >> >> Is there a reason for this preference? > > I think this change is simply incorrect: the first argument of > string-suffix-p is not interpreted as a regexp, but as a simple > literal string (the implementation uses compare-strings internally). But why is it incorrect? `string-suffix-p' is passed a string, while `string-match-p' takes a regular expression, that might be too liberal but should still match everything the previous check did -- or am I missing something? >> Also, I assume you want to quote the period in ".gz\\'"? > > No need to quote it, see above.