From: Philip Kaludercic <philipk@posteo.net>
To: Tony Zorman <tonyzorman@mailbox.org>
Cc: emacs-devel@gnu.org
Subject: Re: package-vc support for :files keyword
Date: Sun, 24 Sep 2023 16:31:27 +0200 [thread overview]
Message-ID: <87wmwfbq2o.fsf@posteo.net> (raw)
In-Reply-To: <87jzsgm82h.fsf@hyperspace> (Tony Zorman's message of "Sun, 24 Sep 2023 07:52:38 +0200")
Tony Zorman <tonyzorman@mailbox.org> writes:
> On Wed, Sep 20 2023 07:32, Philip Kaludercic wrote:
>> + (unless (string-match-p ignored-files file)
>
> One thing that did jump out to me just now, which I hadn't considered
> before: when ignored-files is the empty string, this will always match
> any file—not what we want :)
Do you mean because the empty glob expression doesn't match everything,
but the empty regular expression does?
The easiest solution seems to be to just check if the empty string is
listed and handle that separately (whatever the correct behaviour is in
that case), but on the other hand, why should a user list an empty
string in the list of ignored files?
--
Philip Kaludercic
next prev parent reply other threads:[~2023-09-24 14:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 10:53 package-vc support for :files keyword Daniel Fleischer
2023-06-10 13:23 ` Philip Kaludercic
2023-06-10 14:20 ` Daniel Fleischer
2023-06-11 8:55 ` Philip Kaludercic
2023-06-11 9:30 ` Daniel Fleischer
2023-06-11 10:24 ` Philip Kaludercic
2023-09-18 7:25 ` Tony Zorman
2023-09-18 9:10 ` Philip Kaludercic
2023-09-18 14:43 ` Tony Zorman
2023-09-18 15:52 ` Philip Kaludercic
2023-09-18 18:54 ` Adam Porter
2023-09-19 8:37 ` Philip Kaludercic
2023-09-19 12:23 ` Adam Porter
2023-09-19 13:56 ` Philip Kaludercic
2023-09-19 14:14 ` Adam Porter
2023-09-18 19:40 ` Tony Zorman
2023-09-19 8:47 ` Philip Kaludercic
2023-09-19 13:48 ` Adam Porter
2023-09-19 14:00 ` Philip Kaludercic
2023-09-19 14:17 ` Tony Zorman
2023-09-20 7:32 ` Philip Kaludercic
2023-09-21 13:28 ` Tony Zorman
2023-09-21 16:32 ` Philip Kaludercic
[not found] ` <87jzsgm82h.fsf@hyperspace>
2023-09-24 14:31 ` Philip Kaludercic [this message]
2023-09-25 13:32 ` Tony Zorman
2023-09-27 14:03 ` Philip Kaludercic
2023-10-04 6:44 ` Tony Zorman
2023-09-19 22:51 ` Jonas Bernoulli
2023-09-22 12:38 ` Stefan Kangas
2023-09-22 13:26 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmwfbq2o.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=tonyzorman@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.