From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/hyperdrive b5294b4354 4/4: Tidy: Use zerop instead of = 0 Date: Sun, 15 Oct 2023 09:17:56 +0000 Message-ID: <87wmvogs6z.fsf@posteo.net> References: <169722725606.27637.3820182151024041420@vcs2.savannah.gnu.org> <20231013200057.2C7FCC09BC9@vcs2.savannah.gnu.org> <87mswmqiif.fsf@posteo.net> <87edhw7uug.fsf@dataswamp.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23308"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 15 11:18:51 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qrxGt-0005qr-7K for ged-emacs-devel@m.gmane-mx.org; Sun, 15 Oct 2023 11:18:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrxG9-0004Yk-9r; Sun, 15 Oct 2023 05:18:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrxG7-0004Y3-No for emacs-devel@gnu.org; Sun, 15 Oct 2023 05:18:03 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrxG5-0007EL-Rf for emacs-devel@gnu.org; Sun, 15 Oct 2023 05:18:03 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id A1B6A240027 for ; Sun, 15 Oct 2023 11:17:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1697361477; bh=/Tb49aVMqOBua0isTp594aOrS0faJOr7nCynwbREKYs=; h=From:To:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=Acz5iZtmdqBKWfvFDEltxtmKUWHtRjPqXtwp03SE/8wKKSJ5x1dT2y/5MOs6MRMSK 9IlsGv+w9g6avSEmNX4Odbzd9vXSbFce5KGWj4Pl1vingBp9ez76hkmKEBuLT7JoIb TAax/GXWNDbIw0pobEYv3t2A71yQmz7gtppuV+IP9MJtWQLDZq1/b0JDzXqP4FF8co W5EL1X+vizhu+ryGKfIZ4DdweSUr+aOq9Pwa7DPj+pj7pauUh7LbWwKyxffSj1Z0Db O4YbIX9Evjr9Y+XKuXA6Dma5J9U09dNtSupT9wHjffaYJKRAKpniGDi/leeE4lQKgV Hm7hpTWo+RGkw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4S7ZQs1w2kz6twv for ; Sun, 15 Oct 2023 11:17:57 +0200 (CEST) In-Reply-To: <87edhw7uug.fsf@dataswamp.org> (Emanuel Berg's message of "Sat, 14 Oct 2023 23:33:11 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311482 Archived-At: You dropped me out of the CC's. Emanuel Berg writes: > Philip Kaludercic wrote: > >> FWIW this doesn't matter that much, you can check the >> disassembly to see what is going on after byte compilation: >> >> (disassemble (byte-compile (lambda (a) (= a 0)))) > > byte code: > args: (a) > 0 varref a > 1 constant 0 > 2 eqlsign > 3 return > >> (disassemble (byte-compile (lambda (a) (zerop a)))) > > byte code: > args: (a) > 0 varref a > 1 constant 0 > 2 eqlsign > 3 return > > They are identical, is that what you mean it doesn't matter > that much? My comment was just to indicate that there is no need to change from one to the other, e.g. for performance reasons (which would have been my intuition), but also as a reminder to check the result of byte compilation. > To use `zerop' is maybe more classy - the attitude being to > minimize everything as much as possible - as it is a unary > function (1 argument) while `=', as it is used here, is binary > (2 arguments). > > BTW = can be used unary as well, then it always returns t - > even for nil. (= nil) ; t > > But why do that? As it is more classy to just use t :) I guess?