From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#66394: 29.1; Make register-read-with-preview more useful Date: Wed, 25 Oct 2023 06:10:24 +0200 Message-ID: <87wmvbibpr.fsf@web.de> References: <87il7ib6cu.fsf@posteo.net> <87sf67qqmp.fsf@web.de> <875y3386ep.fsf@posteo.net> <87a5sddh14.fsf@web.de> <8734y5vnj7.fsf@posteo.net> <87bkcslr18.fsf@web.de> <87y1fwtyrl.fsf@posteo.net> <87y1fut1wp.fsf@web.de> <87ttqgpjiz.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30416"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 66394@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 25 06:10:57 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qvVEO-0007lM-S6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Oct 2023 06:10:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qvVE1-000459-LE; Wed, 25 Oct 2023 00:10:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvVE0-000451-NE for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2023 00:10:32 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qvVE0-0004Vc-El for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2023 00:10:32 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qvVEU-0001wb-0Q for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2023 00:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Oct 2023 04:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66394 X-GNU-PR-Package: emacs Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.16982070577461 (code B ref 66394); Wed, 25 Oct 2023 04:11:01 +0000 Original-Received: (at 66394) by debbugs.gnu.org; 25 Oct 2023 04:10:57 +0000 Original-Received: from localhost ([127.0.0.1]:57067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvVEP-0001wG-8C for submit@debbugs.gnu.org; Wed, 25 Oct 2023 00:10:57 -0400 Original-Received: from mout.web.de ([212.227.17.12]:51179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvVEL-0001vz-Gw for 66394@debbugs.gnu.org; Wed, 25 Oct 2023 00:10:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1698207016; x=1698811816; i=michael_heerdegen@web.de; bh=YutlNiwCQYixMt0WAge2YTvr2QEyNEQQADuayC0EWuE=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=JI3q7zZCE0B5tcyLEW6d9i3HqG13bg47ft//v5RyECJ7L0258xxjElYLjE/M2p5+ szqeb1JCl020Nfc5uTEuMjaZ1Ky2RFYjo8ohGe0Zfwb3ebHBPwKNI+NnmhweHDjcZ Vt4mZ4O7JW/KrUz2A7RzNIPocNmsipG4SRLXe5q7AHBtmEZNz656J9Qc1qE1X4dXe jImidddZxn9Uda5qg9DraWAkYvKo+DazDY6VLPZDftHfxj35Ny1jNeTW3PGL1VTcj YUgo0uTDEn7etYhzISY01AfY3xwKURhVlXgdySXrNbwEtPYNdaMBH9lJaDM2RBFJ7 wnAWTTiy26t34z9sJA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([84.59.210.159]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1M43Kc-1qvVDk15Oa-00007u; Wed, 25 Oct 2023 06:10:16 +0200 In-Reply-To: <87ttqgpjiz.fsf@posteo.net> (Thierry Volpiatto's message of "Tue, 24 Oct 2023 07:19:11 +0000") X-Provags-ID: V03:K1:8hHVIwSZte9RAPgUzoaW/JxS8jG3NGx7D5I3jHdhsBn4k2A+zY7 g/Lk1kPdQgEsHqQ7WqCQwzt0hBejlHlY+ARI70k2Uo+1kOo+fKoFKmv6LUbrjdVku3tPQeA 5vDtRU44Qk3yCC7MPx1hID6DMfeSo+/wdO0cSarVi/8KMbdJCKHgGp9V4/r736HADflrBf8 h56R4S1REYgog2/3RWOvg== UI-OutboundReport: notjunk:1;M01:P0:N7XjkybEbv8=;fj4wP9zck2KfgUCtjTOVlcrXiTV LwgEqlWmJRz+XGbezDV7W6zY/IhCWV/RpPk5bjJZBcmT87+RCnV4qoPWmxI0fbjsHXLcjCJmQ IuMrK00KO9tZg4f/1H6BRuk412EYVEQH19NKpHFNlYS2HjyEqLWZmHvzXclL3ej4HTjuxqLTK v07o1Vb6NhH7LoX6t4rhIZhnoT3PmLiCfe7Qhszp4ro1hoy/Cgo9RbuS6l9NARPhk5tsxgt3v 5cE04gWysr+c45l+msO8Q9v2p3kWOIyFiFu9SDGg0aawrabKeRRoJ/haJHvqKBVPtdqn0BYMM Ho+n2ifjtKBN+qo0g3CPyHODhu0ocHMww/FZXU9q9bhEzNn6vM1+Kd4BTaYB86jt0pUG5l7TM /yQRPUdeuoeHaDj8q+YcvxTMhiia/7xmHFRsvuDOMdayOgRNTVOY7WObTX6X84j1wldM3ar7C ARy/WTo5tmSjUa4iLUugFvWL68rFJGlAjMsdwNjn1xkp7mthopSWiYeHjYguzLmuOLP6s/fi9 IuHMjb/RVJMimmPWzgzOaKfBJa4Mf8te0rO5rEhkv5aUuHaRaJngkX15VHFssAszqFegknd+8 eFxx97i2IMIiv33OKmXuMNbLaoJ1F5lYIKHLoqcvLMP9GJc5tI/H9yAo8WX2Mb8PiZacVBUd9 JmbK0hdrtiKGj0mv5gaoZNrTUKYe8F4LfmUK6iNSSUeV01lqQyMM/i6xUsg/jauB50i01uMg0 NCMGCKRoaH8AbJKX/wv0KWkyxqH72V64AI5r9lIFzdct96A81GfCqkj8l1jCqCImTe9ybfDG X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273144 Archived-At: Thierry Volpiatto writes: > A possible solution for this is adding two vars, insert-register-types > and jump-to-register-types and define register-type like this (named > register--type here): > > (defun register--type (register) > ;; Call register/type against the register value. > (register/type (if (consp (cdr register)) > (cadr register) > (cdr register)))) > > (cl-defgeneric register/type (regval)) > > (cl-defmethod register/type ((regval string)) 'string) > (cl-defmethod register/type ((regval number)) 'number) > (cl-defmethod register/type ((regval marker)) 'marker) > (cl-defmethod register/type ((regval window-configuration)) 'window) > (cl-deftype frame-register () '(satisfies frameset-register-p)) > (cl-defmethod register/type :extra "frame-register" (regval) 'frame) > > ;; set a new register and check its type like this: > (register--type (car register-alist)) This looks promising. But I'm not sure whether the detour via type names (instead of an approach using only generics) is the best solution. Why not define just a new generic (register-eligible-for-command-p REG COMMAND) and use that as predicate in the interactive specs of the commands (providing `this-command' as second arg)? Seems simpler to me and still more extensible and controllable. Michael.