bug#67445: Likely Gnus bracketing mistake

bug#67445: Likely Gnus bracketing mistake

[Mattias Engdegård]

This looks like a bracketing mistake (gnus-group.el line 1758):

>     (if (and backward (progn (beginning-of-line)) (bobp))

especially considering `beginning-of-line` always returns nil.

(Is there a Gnus maintainer these days?)

bug#67445: Likely Gnus bracketing mistake

[Eli Zaretskii]

> From: Mattias Engdegård <mattias.engdegard@gmail.com>
> Date: Sat, 25 Nov 2023 15:50:59 +0100
> 
> This looks like a bracketing mistake (gnus-group.el line 1758):
> 
> >     (if (and backward (progn (beginning-of-line)) (bobp))
> 
> especially considering `beginning-of-line` always returns nil.
> 
> (Is there a Gnus maintainer these days?)

Yes, Eric (CC'ed).

bug#67445: Likely Gnus bracketing mistake

[Eric Abrahamsen]

Mattias Engdegård <mattias.engdegard@gmail.com> writes:

> This looks like a bracketing mistake (gnus-group.el line 1758):
>
>>     (if (and backward (progn (beginning-of-line)) (bobp))
>
> especially considering `beginning-of-line` always returns nil.

Yes, it looks like you're right. Let me test a bit.

> (Is there a Gnus maintainer these days?)

It has a janitor :)

bug#67445: Likely Gnus bracketing mistake

[Eric Abrahamsen]

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Mattias Engdegård <mattias.engdegard@gmail.com>
>> Date: Sat, 25 Nov 2023 15:50:59 +0100
>> 
>> This looks like a bracketing mistake (gnus-group.el line 1758):
>> 
>> >     (if (and backward (progn (beginning-of-line)) (bobp))
>> 
>> especially considering `beginning-of-line` always returns nil.

That whole special-case test doesn't seem necessary, I think the
attached patch is sufficient. I've tested it lightly, does it look okay?

>> (Is there a Gnus maintainer these days?)
>
> Yes, Eric (CC'ed).

Hey, I've been promoted!


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-search-articles.diff --]
[-- Type: text/x-patch, Size: 2685 bytes --]

diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el
index 01e6a8f317f..41d92e715ee 100644
--- a/lisp/gnus/gnus-group.el
+++ b/lisp/gnus/gnus-group.el
@@ -1745,45 +1745,43 @@ gnus-group-level
       gnus-level-killed))
 
 (defun gnus-group-search-forward (&optional backward all level first-too)
-  "Find the next newsgroup with unread articles.
-If BACKWARD is non-nil, find the previous newsgroup instead.
-If ALL is non-nil, just find any newsgroup.
-If LEVEL is non-nil, find group with level LEVEL, or higher if no such
-group exists.
-If FIRST-TOO, the current line is also eligible as a target."
+  "Move point to the next newsgroup with unread articles.
+If BACKWARD is non-nil, move to the previous newsgroup instead.
+If ALL is non-nil, consider any newsgroup, not only those with
+unread articles.  If LEVEL is non-nil, find group with level
+LEVEL, or higher if no such group exists.  If FIRST-TOO, the
+current line is also eligible as a target."
   (let ((way (if backward -1 1))
 	(low gnus-level-killed)
 	(beg (point))
 	pos found lev)
-    (if (and backward (progn (beginning-of-line)) (bobp))
-	nil
-      (unless first-too
-	(forward-line way))
-      (while (and
-	      (not (eobp))
-	      (not (setq
-		    found
-		    (and
-		     (get-text-property (point) 'gnus-group)
-		     (or all
-			 (and
-			  (let ((unread
-				 (get-text-property (point) 'gnus-unread)))
-			    (and (numberp unread) (> unread 0)))
-			  (setq lev (get-text-property (point)
-						       'gnus-level))
-			  (<= lev gnus-level-subscribed)))
-		     (or (not level)
-			 (and (setq lev (get-text-property (point)
-							   'gnus-level))
-			      (or (= lev level)
-				  (and (< lev low)
-				       (< level lev)
-				       (progn
-					 (setq low lev)
-					 (setq pos (point))
-					 nil))))))))
-	      (zerop (forward-line way)))))
+    (unless first-too
+      (forward-line way))
+    (while (and
+	    (not (if (> 0 way) (eobp) (bobp)))
+	    (not (setq
+		  found
+		  (and
+		   (get-text-property (point) 'gnus-group)
+		   (or all
+		       (and
+			(let ((unread
+			       (get-text-property (point) 'gnus-unread)))
+			  (and (numberp unread) (> unread 0)))
+			(setq lev (get-text-property (point)
+						     'gnus-level))
+			(<= lev gnus-level-subscribed)))
+		   (or (not level)
+		       (and (setq lev (get-text-property (point)
+							 'gnus-level))
+			    (or (= lev level)
+				(and (< lev low)
+				     (< level lev)
+				     (progn
+				       (setq low lev)
+				       (setq pos (point))
+				       nil))))))))
+	    (zerop (forward-line way))))
     (if found
 	(progn (gnus-group-position-point) t)
       (goto-char (or pos beg))

bug#67445: Likely Gnus bracketing mistake

[Andreas Schwab]

On Nov 25 2023, Eric Abrahamsen wrote:

> +	    (not (if (> 0 way) (eobp) (bobp)))

            (not (if backward (bobp) (eobp))))

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

bug#67445: Likely Gnus bracketing mistake

[Eric Abrahamsen]

On November 25, 2023 1:43:37 PM PST, Andreas Schwab <schwab@linux-m68k.org> wrote:
>On Nov 25 2023, Eric Abrahamsen wrote:
>
>> +	    (not (if (> 0 way) (eobp) (bobp)))
>
>            (not (if backward (bobp) (eobp))))

 Ah, good point! Thanks.

bug#67445: Likely Gnus bracketing mistake

[Mattias Engdegård]

25 nov. 2023 kl. 18.27 skrev Eric Abrahamsen <eric@ericabrahamsen.net>:

> It has a janitor :)

The usual reward for diligence!

bug#67445: Likely Gnus bracketing mistake

[Eric Abrahamsen]

Mattias Engdegård <mattias.engdegard@gmail.com> writes:

> 25 nov. 2023 kl. 18.27 skrev Eric Abrahamsen <eric@ericabrahamsen.net>:
>
>> It has a janitor :)
>
> The usual reward for diligence!

I can always put "maintainer" on my business cards, tho :)

I'm closing this bug, thanks for the report!