From: Ihor Radchenko <yantar92@posteo.net>
To: Morgan Smith <Morgan.J.Smith@outlook.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug
Date: Sun, 31 Dec 2023 14:32:32 +0000 [thread overview]
Message-ID: <87wmsu788v.fsf@localhost> (raw)
In-Reply-To: <CH3PR84MB3424DDE4B98A0ACA7EE15EB1C59CA@CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM>
Morgan Smith <Morgan.J.Smith@outlook.com> writes:
> lisp/org-agenda.el (org-agenda-get-scheduled): Consolidate deadline
> fetching code. Don't check if deadline is shown when
> 'org-agenda-skip-scheduled-if-deadline-is-shown' has a value of
> 'repeated-after-deadline'.
>
> Currently when 'org-agenda-skip-scheduled-if-deadline-is-shown' has a
> value of 'repeated-after-deadline' then there is no effect. This is
> because when 'org-agenda-get-scheduled' is run on later dates, the
> previous deadlines are not put in 'deadline-pos'.
May you please provide a detailed reproducer demonstrating the bug you
are trying to fix? Such reproducer could be a basis of a new test.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-12-31 14:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-30 20:45 [PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug Morgan Smith
2023-12-31 14:32 ` Ihor Radchenko [this message]
2024-01-02 20:25 ` Morgan Smith
2024-01-03 15:29 ` Ihor Radchenko
2024-01-03 17:06 ` Morgan Smith
2024-01-04 14:04 ` Ihor Radchenko
2024-01-16 16:45 ` Morgan Smith
2024-01-16 18:52 ` Ihor Radchenko
2024-01-16 20:37 ` Morgan Smith
2024-01-17 13:10 ` Ihor Radchenko
2024-02-07 12:27 ` Ihor Radchenko
2024-02-07 16:15 ` Bastien Guerry
2024-02-07 16:25 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmsu788v.fsf@localhost \
--to=yantar92@posteo.net \
--cc=Morgan.J.Smith@outlook.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.