From: Philip Kaludercic <philipk@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: mail@daniel-mendler.de, stefankangas@gmail.com,
monnier@iro.umontreal.ca, 66554@debbugs.gnu.org
Subject: bug#66554: [PATCH] Add the public API of Compat to the core
Date: Fri, 12 Jan 2024 07:38:20 +0000 [thread overview]
Message-ID: <87wmsfm26r.fsf@posteo.net> (raw)
In-Reply-To: <83ply7j9by.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Jan 2024 09:32:17 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Philip Kaludercic <philipk@posteo.net>
>> Cc: Daniel Mendler <mail@daniel-mendler.de>, 66554@debbugs.gnu.org,
>> eliz@gnu.org, Stefan Kangas <stefankangas@gmail.com>
>> Date: Thu, 11 Jan 2024 20:24:25 +0000
>>
>> > The addition cab done procedurally, as in
>> >
>> > ;;;;####autoload (push (list 'compat emacs-major-version
>> > emacs-minor-version) package--builtin-versions)
>>
>> If this work, I like this idea a lot! I'll test it out to see if this
>> could simplify things.
>
> I'm not sure I understand the effects of the above -- can you explain?
The idea is to manually register the file as a package while scraping
for autoloads, thereby setting the version of the built-in Compat
package to whatever the current version of Emacs is. My patch adds a
`most-positive-fixnum' to the version number to ensure that the built-in
compat is always (or at least for a more than reasonably long while)
preferred over an external dependency.
The consequence is that we don't have to update any files, and I would
assume we don't have to document anything in make-tarball.txt, because
nothing has to be done when bumping the version of Emacs itself.
> In general, if something needs to be done when the Emacs version is
> bumped, that action should be described in make-tarball.txt. It is a
> nuisance to follow the procedure there, only to be reminded of
> something else via a warning emitted by the build (and that is even
> before we consider the possibility that someone launches a build and
> goes for a coffee, while the warnings scroll on the screen with no one
> to see them). Likewise, if a file is modified by whatever commands we
> invoke to bump an Emacs version, that file should be mentioned in
> make-tarball.txt, because the person who performs that procedure will
> then need to commit the changes with a suitable log message, like we
> do today with configure.ac and the rest.
next prev parent reply other threads:[~2024-01-12 7:38 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 9:35 bug#66554: [PATCH] Add the public API of Compat to the core Philip Kaludercic
2024-01-10 22:02 ` Stefan Kangas
2024-01-11 5:27 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-11 7:54 ` Philip Kaludercic
2024-01-11 8:06 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-11 17:35 ` Philip Kaludercic
2024-01-11 17:58 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-11 19:24 ` Philip Kaludercic
2024-01-11 20:11 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-11 20:24 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-11 20:43 ` Philip Kaludercic
2024-01-11 21:01 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-12 16:29 ` Philip Kaludercic
2024-01-12 18:05 ` Eli Zaretskii
2024-01-12 18:17 ` Philip Kaludercic
2024-01-12 18:29 ` Eli Zaretskii
2024-01-12 18:40 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-12 20:05 ` Eli Zaretskii
2024-01-12 22:27 ` Philip Kaludercic
2024-01-13 6:44 ` Eli Zaretskii
2024-01-13 12:23 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-18 19:51 ` Philip Kaludercic
2024-01-18 20:17 ` Eli Zaretskii
2024-01-18 20:33 ` Stefan Kangas
2024-01-19 6:40 ` Eli Zaretskii
2024-01-19 6:52 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-18 20:35 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-19 6:43 ` Eli Zaretskii
2024-01-19 6:57 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-19 16:44 ` Philip Kaludercic
2024-01-19 18:50 ` Eli Zaretskii
2024-01-24 6:23 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-26 7:58 ` Philip Kaludercic
2024-01-26 10:42 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-26 12:35 ` Eli Zaretskii
2024-02-01 15:53 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-02 8:11 ` Philip Kaludercic
2024-02-02 12:36 ` Eli Zaretskii
2024-02-06 19:10 ` Philip Kaludercic
2024-02-06 19:37 ` Eli Zaretskii
2024-02-06 19:59 ` Philip Kaludercic
2024-02-07 17:15 ` Philip Kaludercic
2024-02-07 17:31 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-07 17:43 ` Eli Zaretskii
2024-02-08 7:40 ` Philip Kaludercic
2024-02-08 8:21 ` Eli Zaretskii
2024-02-08 10:47 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-10 16:29 ` Philip Kaludercic
2024-02-10 16:36 ` Eli Zaretskii
2024-02-10 16:46 ` Philip Kaludercic
2024-02-10 17:20 ` Eli Zaretskii
2024-02-10 17:40 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-10 17:47 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-10 18:03 ` Eli Zaretskii
2024-02-10 18:00 ` Eli Zaretskii
2024-02-10 18:14 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-10 19:12 ` Eli Zaretskii
2024-02-11 21:52 ` Philip Kaludercic
2024-01-18 20:47 ` Philip Kaludercic
2024-01-19 6:47 ` Eli Zaretskii
2024-01-18 20:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-18 20:41 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-18 23:34 ` Stefan Kangas
2024-01-19 5:49 ` Philip Kaludercic
2024-01-19 6:42 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-12 8:10 ` Eli Zaretskii
2024-01-11 20:24 ` Philip Kaludercic
2024-01-11 20:40 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-12 7:32 ` Eli Zaretskii
2024-01-12 7:38 ` Philip Kaludercic [this message]
2024-01-12 11:54 ` Eli Zaretskii
2024-01-11 10:32 ` Eli Zaretskii
2024-01-11 19:35 ` Stefan Kangas
2024-01-11 20:07 ` Philip Kaludercic
2024-01-12 7:12 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmsfm26r.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=66554@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mail@daniel-mendler.de \
--cc=monnier@iro.umontreal.ca \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.