From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
Received: from mp2.migadu.com ([2001:41d0:303:e16b::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms8.migadu.com with LMTPS
	id cGzbKQ3Qo2Wa0wAAe85BDQ:P1
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sun, 14 Jan 2024 13:14:05 +0100
Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp2.migadu.com with LMTPS
	id cGzbKQ3Qo2Wa0wAAe85BDQ
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sun, 14 Jan 2024 13:14:05 +0100
X-Envelope-To: larch@yhetil.org
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=posteo.net header.s=2017 header.b=KwtU8idT;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org";
	dmarc=pass (policy=none) header.from=posteo.net
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1705234445;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=7KNLuQKKerZPRNFFuluk3OOl5QpeaHnKnrgFVaaQFeI=;
	b=RSnpsCiQSorXa72CVEJOn+C7N51xP7djeooU7V/UXW81NRM5q1Eb6cBLSbhs93EmY2g563
	57RxSB7I5n1rAWkozbTrMkFlbIZSdGdUAKf4tQHoJnxzeoeOiBha9JN2Z0YgUh2UBl3q8b
	i8aCEWNk/MRNTc7U2fljwW/eiiNLY7O/NMnjuVmvub5HesHfO4E901JxpBU9UNO2bkkuoK
	yegmAXe6kVngGhp/QehDrm/kdpt62Fpq9qKLqLoRr0OkC9iUX1fYw1aseanHpehvAOOGBB
	7i4uonyX8y0KotNyt3WxHYrIc+ykmY2I/9y02BxBZprtur4IvWD9m5Z/r+LS5w==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=posteo.net header.s=2017 header.b=KwtU8idT;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org";
	dmarc=pass (policy=none) header.from=posteo.net
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705234445; a=rsa-sha256; cv=none;
	b=C4cIxfzkNwQPqiQCkSeyz4EsRv74KtZehfuJkIAXoMl74pdooa0xGrYJCNHmJTJlI9bKfX
	qgjs/7hxZeHROn4QAvfaaMQgutkBaLXkK5GcRJxJILHKGA2if6KG4GXD4VYcRuGz2umGyW
	PWFdAnrAf4Tnb7Meq2lMO/6h97AoWpTeSC09g0Bd+kcAJGavavD3kkzSLjpbz9Ploumk2C
	I6IIRHefCKT5y7VeRb4i2M0FS4A3Dkr6eUQb1icaY2D0tgNec0m0PV9UUEZuQxxK0CNml5
	6PkWc83qnUMVyOhkRE5hV7RaPPzJA3K0q6ZBIf+P404wVlG10eXayvJ8doGidQ==
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 7F9D4523AE
	for <larch@yhetil.org>; Sun, 14 Jan 2024 13:14:05 +0100 (CET)
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-orgmode-bounces@gnu.org>)
	id 1rOzMp-0005rP-9B; Sun, 14 Jan 2024 07:13:31 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <yantar92@posteo.net>)
 id 1rOzMo-0005pz-9g
 for emacs-orgmode@gnu.org; Sun, 14 Jan 2024 07:13:30 -0500
Received: from mout01.posteo.de ([185.67.36.65])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <yantar92@posteo.net>)
 id 1rOzMk-0002Pw-OA
 for emacs-orgmode@gnu.org; Sun, 14 Jan 2024 07:13:30 -0500
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id AC2F4240028
 for <emacs-orgmode@gnu.org>; Sun, 14 Jan 2024 13:13:23 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1705234403; bh=zQ+ATzDInsQMRgCUUBuin4GOL3w8JMsqLYt61AZ8CQM=;
 h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From;
 b=KwtU8idTsTeZscJspo7z5Mz7b9NNzfQGaLh61EZ65DtFHzsSJkftgI14KFj1cVhgQ
 co2Y/ieAlxFvagu4wYMlB7euRT/acSHf1nCEjGGzAfeREDymApkn+GWWdWL1HJhNwp
 apf0UQnX3j60mLxMzFtxrW2m5PDk2N8KsPW5dKsGaRms8oLIaubBEWRM/BNisXRMK6
 nxmm3R+T3dCM9vGJOCumssH3EIK8fgsEl1Q+JsVN5d1QKc9zYabmYvaN20aiioKq9l
 nu7SyRV7BDUzrXobQeWb1kUnrvEml/998esUDT9EbRioE3DGkhhEix+IHSW6HKJlZ6
 7SslBFiRsxqfQ==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4TCZ1H0R4Cz6twQ;
 Sun, 14 Jan 2024 13:13:22 +0100 (CET)
From: Ihor Radchenko <yantar92@posteo.net>
To: gerard.vermeulen@posteo.net
Cc: Emacs orgmode <emacs-orgmode@gnu.org>,
 emacs-orgmode-bounces+gerard.vermeulen=posteo.net@gnu.org
Subject: Re: [PATCH] org-babel-demarcate-block: split using element API
In-Reply-To: <d8b697ea29507e007601198401689e08@posteo.net>
References: <7e41f9b6e9026a404e256f33371e974c@posteo.net>
 <87zfxq78ff.fsf@localhost> <d02fe29f0b7bb9375b1bcdce15089b35@posteo.net>
 <87zfxo3taa.fsf@localhost> <e0252d664af25728243734d67432ad64@posteo.net>
 <87v88a78qd.fsf@localhost> <7f23ea966f0f0aad3fad29b0b96864f3@posteo.net>
 <87y1d55fc6.fsf@localhost> <37fdcc4bfcf734c2e5ec439d40b4f7d8@posteo.net>
 <878r50yqmo.fsf@localhost> <442006329cfba666710c989aece5191a@posteo.net>
 <c4a1570502fd3b3f4df0c7880c2c0a96@posteo.net>
 <261356c53e857e0bc4b04f884366edfa@posteo.net> <87bk9uy31w.fsf@localhost>
 <680e4a4fccf4f3c5c8f51d8215257eff@posteo.net> <87a5p9uute.fsf@localhost>
 <dfa1c7a1968677d42715ffd0e3e2d51d@posteo.net>
 <d8b697ea29507e007601198401689e08@posteo.net>
Date: Sun, 14 Jan 2024 12:16:35 +0000
Message-ID: <87wmscrty4.fsf@localhost>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net;
 helo=mout01.posteo.de
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-orgmode@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
X-Migadu-Country: US
X-Migadu-Flow: FLOW_IN
X-Migadu-Queue-Id: 7F9D4523AE
X-Migadu-Scanner: mx13.migadu.com
X-Migadu-Spam-Score: -5.27
X-Spam-Score: -5.27
X-TUID: QPR4QjkZft2f

gerard.vermeulen@posteo.net writes:

> New patch attached.

I tried make test and the tests are still failing with this new patch:

1 unexpected results:
   FAILED  test-ob/demarcate-block  ((should (string= region-text (org-trim (nth 1 info)))) :form (string= "mark this line as region" "") :value nil :explanation (arrays-of-different-length 24 0 "mark this line as region" "" first-mismatch-at 0))


-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>