From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#70840: 29.3; ERC 5.5.0.29.1: erc-kill-buffer-on-part kills server buffer Date: Tue, 28 May 2024 06:36:36 -0700 Message-ID: <87wmnenjmj.fsf__14962.0971105591$1716903443$gmane$org@neverwas.me> References: <7hseysqbu1.fsf@thibaut.dev> <8734ql9ppd.fsf@neverwas.me> <87seyj6wgh.fsf@neverwas.me> <87wmnt5bun.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31059"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Thibaut Meyer , emacs-erc@gnu.org To: 70840-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 28 15:37:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBx0t-0007qR-DE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 May 2024 15:37:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBx0a-0007Jb-Bn; Tue, 28 May 2024 09:36:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBx0X-0007Da-Mz for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 09:36:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBx0X-0001cU-Eh for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 09:36:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sBx0g-0000iM-JD for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 09:37:02 -0400 Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 May 2024 13:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 70840 X-GNU-PR-Package: emacs Mail-Followup-To: 70840@debbugs.gnu.org, jp@neverwas.me, thibaut@thibaut.dev Original-Received: via spool by 70840-done@debbugs.gnu.org id=D70840.17169034172719 (code D ref 70840); Tue, 28 May 2024 13:37:02 +0000 Original-Received: (at 70840-done) by debbugs.gnu.org; 28 May 2024 13:36:57 +0000 Original-Received: from localhost ([127.0.0.1]:45991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBx0b-0000hk-48 for submit@debbugs.gnu.org; Tue, 28 May 2024 09:36:57 -0400 Original-Received: from mail-108-mta87.mxroute.com ([136.175.108.87]:38045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBx0Y-0000hK-1N for 70840-done@debbugs.gnu.org; Tue, 28 May 2024 09:36:55 -0400 Original-Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta87.mxroute.com (ZoneMTA) with ESMTPSA id 18fbf6ad672000efce.001 for <70840-done@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 28 May 2024 13:36:41 +0000 X-Zone-Loop: f54f525ced925b782f0c4b14c0b400836500141146c7 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eLjiQU545kphz2vlvgU7CQKJavKCf1IFnzdEiAkA2Gw=; b=BQQqv5DKgIDOwfbqTF67E5aYew +Tzs3BlEoXFxMnnL9he/9WRBjpZrLeTt2IKcyD3/9nVbMbnWSSBsum3ruBzk+j8j/xNVoOHIt5d0p 42aVECrXektV3Gm2HHVEM4atEIWHEDPM8BvuPd29dyuBY0MdhwKFOgDHVkWf4DPlAZFltJh2n7V5c edu6JX6Dx6nOvreMryXf+8UrqbO9ps05rVZUr1IO0wBDp4+AMp7uaeN7EACeBnLeoqqlQxRY1AqFH zYvqzyOcCO0ZxDTBQeEvN82+HoWHCjO3bPKIgGLgCRNxHgquhhZwGcgOYjj/DC9GruVCTc89eKUDa GuNP4daw==; In-Reply-To: <87wmnt5bun.fsf@neverwas.me> (J. P.'s message of "Thu, 16 May 2024 20:57:52 -0700") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286087 Archived-At: "J.P." writes: > After thinking a bit more on this, I've flip-flopped entirely on the > notion of running `erc-part-hook' in `erc-kill-channel' and inhibiting > it in `erc-server-PART' with a would-be null buffer argument. Basically, > I've come to believe the current faulty behavior has been around too > long to justify such a change in the name of fixing a bug that's only > tangentially related. Instead, I think we should introduce a flag that > `erc-kill-channel-hook' members can use to detect when `erc-server-PART' > is killing a buffer on behalf of the option `erc-kill-buffer-on-part'. > Updated patch attached. Thanks. I've installed something similar as cf7cc4c630a Don't kill server buffer with erc-kill-buffer-on-part Thanks and closing.